From: Bart Van Assche <bvanassche@acm.org>
To: "King, Colin" <colin.king@intel.com>,
Christian Loehle <christian.loehle@arm.com>,
Jens Axboe <axboe@kernel.dk>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpuidle: psd: add power sleep demotion prevention for fast I/O devices
Date: Sun, 23 Mar 2025 05:35:59 -0700 [thread overview]
Message-ID: <1ae51ccc-66cc-4551-b649-2f5883e2f5a2@acm.org> (raw)
In-Reply-To: <SJ2PR11MB7670F63C7052C88637D305DF8DDF2@SJ2PR11MB7670.namprd11.prod.outlook.com>
On 3/17/25 3:03 AM, King, Colin wrote:
> This code is optional, one can enable it or disable it via the config option. Also,
> even when it is built-in one can disable it by writing 0 to the sysfs file
> /sys/devices/system/cpu/cpuidle/psd_cpu_lat_timeout_ms
I'm not sure we need even more configuration knobs in sysfs. How are
users expected to find this configuration option? How should they
decide whether to enable or to disable it?
Please take a look at this proposal and let me know whether this would
solve the issue that you are looking into: "[LSF/MM/BPF Topic] Energy-
Efficient I/O" (https://lore.kernel.org/linux-block/ad1018b6-7c0b-4d70-
b845-c869287d3cf3@acm.org/). The only disadvantage of this approach
compared to the cpuidle patch is that it requires RPM (runtime power
management) to be enabled. Maybe I should look into modifying the
approach such that it does not rely on RPM.
Thanks,
Bart.
next prev parent reply other threads:[~2025-03-23 12:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <33882f284ac6e6d1ec766ca4bb2f3b88@intel.com>
2025-03-03 22:24 ` [PATCH] cpuidle: psd: add power sleep demotion prevention for fast I/O devices Christian Loehle
2025-03-17 10:03 ` King, Colin
2025-03-23 9:18 ` Christian Loehle
2025-03-26 15:14 ` King, Colin
2025-03-23 12:35 ` Bart Van Assche [this message]
2025-03-26 15:04 ` King, Colin
2025-03-26 15:14 ` Rafael J. Wysocki
2025-03-26 16:26 ` Christian Loehle
2025-03-26 17:46 ` Rafael J. Wysocki
2025-04-01 15:03 ` King, Colin
2025-04-01 15:15 ` Christian Loehle
2025-04-01 16:41 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ae51ccc-66cc-4551-b649-2f5883e2f5a2@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=christian.loehle@arm.com \
--cc=colin.king@intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox