Linux block layer
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	Jens Axboe <axboe@kernel.dk>
Cc: Damien Le Moal <dlemoal@kernel.org>,
	Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH for-next v4 0/5] null_blk: improve write failure simulation
Date: Wed, 22 Jan 2025 01:02:50 +0000	[thread overview]
Message-ID: <1b7bb875-292d-44e4-a673-5a285110ddb3@nvidia.com> (raw)
In-Reply-To: <3927c72c-7cb9-4d91-9296-fb0e70b64354@nvidia.com>

Replying to my own email :-

On 1/21/25 17:01, Chaitanya Kulkarni wrote:
> On 1/21/25 00:15, Shin'ichiro Kawasaki wrote:
>> Currently, null_blk has 'badblocks' parameter to simulate IO failures
>> for broken blocks. This helps checking if userland tools can handle IO
>> failures. However, this badblocks feature has two differences from the
>> IO failures on real storage devices. Firstly, when write operations fail
>> for the badblocks, null_blk does not write any data, while real storage
>> devices sometimes do partial data write. Secondly, null_blk always make
>> write operations fail for the specified badblocks, while real storage
>> devices can recover the bad blocks so that next write operations can
>> succeed after failure. Hence, real storage devices are required to check
>> if userland tools support such partial writes or bad blocks recovery.
>>
>> This series improves write failure simulation by null_blk to allow
>> checking userland tools without real storage devices. The first patch
>> is a preparation to make new feature addition simpler. The second patch
>> introduces the 'badblocks_once' parameter to simulate bad blocks
>> recovery. The third patch fixes a bug, and the fourth patch adds a
>> function argument to prepare for the fifth patch. The fifth patch adds
>> the partial IO support and introduces the 'badblocks_partial_io'
>> parameter.
>

For the whole series :-

> Looks good.
>
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
>
> -ck
>
>


      reply	other threads:[~2025-01-22  1:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21  8:15 [PATCH for-next v4 0/5] null_blk: improve write failure simulation Shin'ichiro Kawasaki
2025-01-21  8:15 ` [PATCH for-next v4 1/5] null_blk: generate null_blk configfs features string Shin'ichiro Kawasaki
2025-01-21  8:15 ` [PATCH for-next v4 2/5] null_blk: introduce badblocks_once parameter Shin'ichiro Kawasaki
2025-01-21  8:15 ` [PATCH for-next v4 3/5] null_blk: fix zone resource management for badblocks Shin'ichiro Kawasaki
2025-01-23  3:37   ` Damien Le Moal
2025-01-24  4:25     ` Shinichiro Kawasaki
2025-01-21  8:15 ` [PATCH for-next v4 4/5] null_blk: pass transfer size to null_handle_rq() Shin'ichiro Kawasaki
2025-01-21  8:15 ` [PATCH for-next v4 5/5] null_blk: do partial IO for bad blocks Shin'ichiro Kawasaki
2025-01-22  1:01 ` [PATCH for-next v4 0/5] null_blk: improve write failure simulation Chaitanya Kulkarni
2025-01-22  1:02   ` Chaitanya Kulkarni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b7bb875-292d-44e4-a673-5a285110ddb3@nvidia.com \
    --to=chaitanyak@nvidia.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=dlemoal@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox