From: Jens Axboe <axboe@kernel.dk>
To: Uday Shankar <ushankar@purestorage.com>,
Ming Lei <ming.lei@redhat.com>, Shuah Khan <shuah@kernel.org>
Cc: linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] selftests: ublk: kublk: build with -Werror
Date: Wed, 23 Apr 2025 18:18:37 -0600 [thread overview]
Message-ID: <1c7744df-329f-4b95-9afb-a005a358851b@kernel.dk> (raw)
In-Reply-To: <20250423-ublk_selftests-v1-1-7d060e260e76@purestorage.com>
On 4/23/25 3:29 PM, Uday Shankar wrote:
> Heeding compiler warnings is generally a good idea, and is easy to do
> for kublk since there is not much source code. Turn warnings into errors
> so that anyone making changes is forced to heed them.
Honestly not a fan of this, it tends to cause random warnings on
different compilers, and then just causing trouble for people
rather than being useful. If you think it's a good idea, make
it follow CONFIG_WERROR at least, don't make it unconditional.
--
Jens Axboe
next prev parent reply other threads:[~2025-04-24 0:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 21:29 [PATCH 0/2] selftests: ublk: misc fixes Uday Shankar
2025-04-23 21:29 ` [PATCH 1/2] selftests: ublk: kublk: build with -Werror Uday Shankar
2025-04-24 0:08 ` Ming Lei
2025-04-24 0:18 ` Jens Axboe [this message]
2025-04-23 21:29 ` [PATCH 2/2] selftests: ublk: common: fix _get_disk_dev_t for pre-9.0 coreutils Uday Shankar
2025-04-24 0:08 ` Ming Lei
2025-04-24 12:31 ` (subset) [PATCH 0/2] selftests: ublk: misc fixes Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c7744df-329f-4b95-9afb-a005a358851b@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=shuah@kernel.org \
--cc=ushankar@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox