From: Jens Axboe <axboe@fb.com>
To: Hannes Reinecke <hare@suse.de>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Omar Sandoval <osandov@osandov.com>
Subject: Re: [PATCH] queue stall with blk-mq-sched
Date: Tue, 24 Jan 2017 09:03:26 -0700 [thread overview]
Message-ID: <1c9beccc-c7cc-dd3e-703d-e91d8110ec86@fb.com> (raw)
In-Reply-To: <aa1c23e1-1beb-a26d-3e77-fe78aa281771@suse.de>
On 01/24/2017 08:54 AM, Hannes Reinecke wrote:
> Hi Jens,
>
> I'm trying to debug a queue stall with your blk-mq-sched branch; with my
> latest mpt3sas patches fio stops basically directly after starting a
> sequential read :-(
>
> I've debugged things and came up with the attached patch; we need to
> restart waiters with blk_mq_tag_idle() after completing a tag.
> We're already calling blk_mq_tag_busy() when fetching a tag, so I think
> calling blk_mq_tag_idle() is required when retiring a tag.
I'll take a look at this. It sounds like all your grief is related to
shared tag maps, which I don't have anything that uses here. I'll see
if we are leaking it, you should be able to check that by reading the
'active' file in the sysfs directory.
--
Jens Axboe
next prev parent reply other threads:[~2017-01-24 16:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 15:54 [PATCH] queue stall with blk-mq-sched Hannes Reinecke
2017-01-24 16:03 ` Jens Axboe [this message]
2017-01-24 18:45 ` Hannes Reinecke
2017-01-24 16:09 ` Jens Axboe
2017-01-24 18:49 ` Hannes Reinecke
2017-01-24 19:55 ` Jens Axboe
2017-01-24 22:06 ` Jens Axboe
2017-01-25 7:39 ` Hannes Reinecke
2017-01-25 8:07 ` Hannes Reinecke
2017-01-25 11:10 ` Hannes Reinecke
2017-01-25 15:52 ` Jens Axboe
2017-01-25 16:57 ` Hannes Reinecke
2017-01-25 17:03 ` Jens Axboe
2017-01-25 17:42 ` Jens Axboe
2017-01-25 22:27 ` Jens Axboe
2017-01-26 16:35 ` Hannes Reinecke
2017-01-26 16:42 ` Jens Axboe
2017-01-26 19:20 ` Jens Axboe
2017-01-27 6:58 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c9beccc-c7cc-dd3e-703d-e91d8110ec86@fb.com \
--to=axboe@fb.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).