From: Keith Busch <keith.busch@intel.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Ming Lei <tom.leiming@gmail.com>,
linux-block@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>,
Dan Williams <dan.j.williams@intel.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Sagi Grimberg <sagig@mellanox.com>,
Mike Snitzer <snitzer@redhat.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Cathy Avery <cavery@redhat.com>
Subject: Re: [PATCH RFC] block: fix bio merge checks when virt_boundary is set
Date: Thu, 17 Mar 2016 16:39:46 +0000 [thread overview]
Message-ID: <20160317163946.GC6217@localhost.lm.intel.com> (raw)
In-Reply-To: <87egb94agz.fsf@vitty.brq.redhat.com>
On Thu, Mar 17, 2016 at 12:20:28PM +0100, Vitaly Kuznetsov wrote:
> Keith Busch <keith.busch@intel.com> writes:
> > been combined. In any case, I think you can get what you're after just
> > by moving the gap check after BIOVEC_PHYS_MERGABLE. Does the following
> > look ok to you?
> >
>
> Thanks, it does.
Cool, thanks for confirming.
> Will you send it or would you like me to do that with your Suggested-by?
I'm not confident yet this doesn't break anything, particularly since
we moved the gap check after the length check. Just wanted to confirm
the concept addressed your concern, but still need to take a closer look
and test before submitting.
next prev parent reply other threads:[~2016-03-17 16:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 15:17 [PATCH RFC] block: fix bio merge checks when virt_boundary is set Vitaly Kuznetsov
2016-03-15 16:03 ` Keith Busch
2016-03-16 10:17 ` Vitaly Kuznetsov
2016-03-16 15:40 ` Ming Lei
2016-03-16 16:26 ` Vitaly Kuznetsov
2016-03-16 22:38 ` Keith Busch
2016-03-17 11:20 ` Vitaly Kuznetsov
2016-03-17 16:39 ` Keith Busch [this message]
2016-03-18 2:59 ` Ming Lei
2016-03-30 13:07 ` Ming Lei
2016-04-20 13:48 ` Vitaly Kuznetsov
2016-12-15 14:03 ` Dexuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317163946.GC6217@localhost.lm.intel.com \
--to=keith.busch@intel.com \
--cc=axboe@kernel.dk \
--cc=cavery@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=kys@microsoft.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sagig@mellanox.com \
--cc=snitzer@redhat.com \
--cc=tom.leiming@gmail.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).