From: Christoph Hellwig <hch@infradead.org>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
viro@zeniv.linux.org.uk, axboe@fb.com, milosz@adfin.com,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-api@vger.kernel.org
Subject: Re: [PATCH 2/6] vfs: vfs: Define new syscalls preadv2,pwritev2
Date: Mon, 25 Apr 2016 01:47:15 -0700 [thread overview]
Message-ID: <20160425084715.GA29255@infradead.org> (raw)
In-Reply-To: <5714E676.4090007@gmail.com>
On Mon, Apr 18, 2016 at 02:51:50PM +0100, Michael Kerrisk (man-pages) wrote:
> Thanks. I applied the patch, but I see one point where the doc
> and code differ, and I suspect that the code needs to be fixed.
> See below.
> > .TP
> > .B EINVAL
> > The vector count \fIiovcnt\fP is less than zero or greater than the
> > -permitted maximum.
> > +permitted maximum. Or, an unknown flag is specified in \fIflags\fP.
>
> In the case described in the last sentence, the code currently appears
> to be returning EOPNOTSUPP. EINVAL is more usual here, so I think the
> code needs adjusting. Your thoughts?
I'd rather update the man page - EOPNOTSUPP is a much more descriptive
error code for this case. I'll send you a patch.
next prev parent reply other threads:[~2016-04-25 8:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1457017443-17662-1-git-send-email-hch@lst.de>
2016-03-03 15:03 ` [PATCH 2/6] vfs: vfs: Define new syscalls preadv2,pwritev2 Christoph Hellwig
2016-03-10 18:15 ` Michael Kerrisk (man-pages)
2016-03-11 9:53 ` Christoph Hellwig
2016-04-18 13:51 ` Michael Kerrisk (man-pages)
2016-04-25 8:47 ` Christoph Hellwig [this message]
2016-04-25 17:35 ` Michael Kerrisk (man-pages)
2016-05-08 9:29 ` Christoph Hellwig
2016-03-03 15:04 ` [PATCH 4/6] vfs: add the RWF_HIPRI flag for preadv2/pwritev2 Christoph Hellwig
2016-05-08 21:47 ` NeilBrown
2016-05-11 8:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425084715.GA29255@infradead.org \
--to=hch@infradead.org \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=milosz@adfin.com \
--cc=mtk.manpages@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).