From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:38667 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750697AbcFANo3 (ORCPT ); Wed, 1 Jun 2016 09:44:29 -0400 Date: Wed, 1 Jun 2016 06:44:27 -0700 From: Christoph Hellwig To: Ming Lei Cc: Mike Snitzer , Jens Axboe , Linux Kernel Mailing List , linux-block@vger.kernel.org, Christoph Hellwig , Al Viro , "open list:DRBD DRIVER" , Jan Kara , Joe Thornber , Keith Busch , Kent Overstreet , "Kirill A. Shutemov" , "Martin K. Petersen" , Michal Hocko , NeilBrown , Sagi Grimberg , Shaohua Li , Steven Whitehouse , Tejun Heo , "open list:XFS FILESYSTEM" Subject: Re: [PATCH v6 0/8] block: prepare for multipage bvecs Message-ID: <20160601134427.GA15888@infradead.org> References: <1464615294-9946-1-git-send-email-ming.lei@canonical.com> <20160531155348.GA24840@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On Wed, Jun 01, 2016 at 08:38:41PM +0800, Ming Lei wrote: > > be dm-crypt.c. Maybe you've identified some indirect use of > > BIO_MAX_SIZE? > > I mean the recently introduced BIO_MAX_SIZE in -next tree: > > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/md/dm-crypt.c?id=4ed89c97b0706477b822ea2182827640c0cec486 The crazy bcache bios striking back once again. I really think it's harmful having a _MAX value and then having a minor driver reinterpreting it and sending larger ones. Until we can lift the maximum limit in general nad have common code exercise it we really need to stop bcache from sending these instead of littering the tree with workarounds.