From: Christoph Hellwig <hch@infradead.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Mike Snitzer <snitzer@redhat.com>,
Christoph Hellwig <hch@infradead.org>, Shaohua Li <shli@fb.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
sitsofe@yahoo.com, axboe@fb.com, Kernel-team@fb.com
Subject: Re: block: correctly fallback for zeroout
Date: Mon, 6 Jun 2016 23:38:42 -0700 [thread overview]
Message-ID: <20160607063842.GA21032@infradead.org> (raw)
In-Reply-To: <yq1mvmxohix.fsf@sermon.lab.mkp.net>
On Mon, Jun 06, 2016 at 10:32:38PM -0400, Martin K. Petersen wrote:
> >>>>> "Mike" == Mike Snitzer <snitzer@redhat.com> writes:
>
> Mike> But hch was originally in favor of _always_ dropping EOPNOTSUPP on
> Mike> the floor (that is what his commit 38f25255330 did). Then he said
> Mike> he disagrees with these interfaces playing games with masking
> Mike> EOPNOTSUPP -- to which you seemingly really don't agree. Unless
> Mike> I'm completely misreading you.
>
> Userland apps rely on EOPNOTSUPP, we can't break that.
Rely on what exactly? Current we return EOPNOTSUPP if the device
doesn't claim to support discards, but it returns 0 if the device first
claims to support it but then fails the I/O.
next prev parent reply other threads:[~2016-06-07 6:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 18:08 [PATCH] block: correctly fallback for zeroout Shaohua Li
2016-05-29 6:47 ` Christoph Hellwig
2016-06-03 3:06 ` Martin K. Petersen
2016-06-03 3:54 ` Mike Snitzer
2016-06-07 2:32 ` Martin K. Petersen
2016-06-07 6:38 ` Christoph Hellwig [this message]
2016-06-10 2:05 ` Martin K. Petersen
[not found] ` <20160527054918.GA9521@sucs.org>
2016-05-28 9:27 ` [PATCH] " Sitsofe Wheeler
2016-06-02 16:58 ` Shaohua Li
2016-06-02 17:02 ` Martin K. Petersen
2016-06-03 2:56 ` Martin K. Petersen
2016-06-03 3:26 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607063842.GA21032@infradead.org \
--to=hch@infradead.org \
--cc=Kernel-team@fb.com \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shli@fb.com \
--cc=sitsofe@yahoo.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).