From: Keith Busch <keith.busch@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org,
Armen Baloyan <armenx.baloyan@intel.com>,
Jay Freyensee <james.p.freyensee@intel.com>,
Ming Lin <ming.l@ssi.samsung.com>,
Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH 6/8] nvme-fabrics: add a generic NVMe over Fabrics library
Date: Wed, 15 Jun 2016 15:16:03 -0400 [thread overview]
Message-ID: <20160615191603.GC1919@localhost.localdomain> (raw)
In-Reply-To: <1465829128-22993-7-git-send-email-hch@lst.de>
On Mon, Jun 13, 2016 at 04:45:26PM +0200, Christoph Hellwig wrote:
> @@ -107,10 +108,19 @@ struct nvme_ctrl {
> u8 event_limit;
> u8 vwc;
> u32 vs;
> + u32 sgls;
> bool subsystem;
> unsigned long quirks;
> struct work_struct scan_work;
> struct work_struct async_event_work;
> +
> + /* Fabrics only */
> + u16 sqsize;
> + u32 ioccsz;
> + u32 iorcsz;
> + u16 icdoff;
> + u16 maxcmd;
> + struct nvmf_ctrl_options *opts;
> };
The pci only stuff goes in 'struct nvme_dev' and embeds 'struct
nvme_ctrl', but fabrics gets to use nvme_ctrl directly?
If we need transport specifics for anything, like you have during
nvme_init_identify, I think we should add function callbacks to
nvme_ctrl_ops to set up those specifics, then we don't need 'is_fabrics'
checks.
next prev parent reply other threads:[~2016-06-15 19:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 14:45 generic NVMe over Fabrics library support V2 Christoph Hellwig
2016-06-13 14:45 ` [PATCH 1/8] blk-mq: add blk_mq_alloc_request_hctx Christoph Hellwig
2016-06-13 14:45 ` [PATCH 2/8] nvme: allow transitioning from NEW to LIVE state Christoph Hellwig
2016-06-13 14:45 ` [PATCH 3/8] nvme: Modify and export sync command submission for fabrics Christoph Hellwig
2016-06-13 14:45 ` [PATCH 4/8] nvme: add fabrics sysfs attributes Christoph Hellwig
2016-06-13 14:45 ` [PATCH 5/8] nvme.h: add NVMe over Fabrics definitions Christoph Hellwig
2016-06-13 14:45 ` [PATCH 6/8] nvme-fabrics: add a generic NVMe over Fabrics library Christoph Hellwig
2016-06-15 19:16 ` Keith Busch [this message]
2016-06-15 19:16 ` Sagi Grimberg
2016-06-13 14:45 ` [PATCH 7/8] nvme.h: Add keep-alive opcode and identify controller attribute Christoph Hellwig
2016-06-13 14:45 ` [PATCH 8/8] nvme: add keep-alive support Christoph Hellwig
2016-06-15 19:54 ` generic NVMe over Fabrics library support V2 Keith Busch
-- strict thread matches above, loose matches on Subject: below --
2016-06-06 21:21 generic NVMe over Fabrics library support Christoph Hellwig
2016-06-06 21:21 ` [PATCH 6/8] nvme-fabrics: add a generic NVMe over Fabrics library Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615191603.GC1919@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=armenx.baloyan@intel.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=james.p.freyensee@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=ming.l@ssi.samsung.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox