From: kbuild test robot <lkp@intel.com>
To: Tahsin Erdogan <tahsin@google.com>
Cc: kbuild-all@01.org, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Tahsin Erdogan <tahsin@google.com>
Subject: [PATCH] block: fix boolreturn.cocci warnings
Date: Sat, 2 Jul 2016 18:17:41 +0800 [thread overview]
Message-ID: <20160702101741.GA101651@lkp-sb04> (raw)
In-Reply-To: <1467429991-18469-1-git-send-email-tahsin@google.com>
block/elevator.c:73:9-10: WARNING: return of 0/1 in function 'elv_bio_merge_ok' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
CC: Tahsin Erdogan <tahsin@google.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
elevator.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -70,12 +70,12 @@ static int elv_iosched_allow_bio_merge(s
bool elv_bio_merge_ok(struct request *rq, struct bio *bio)
{
if (!blk_rq_merge_ok(rq, bio))
- return 0;
+ return false;
if (!elv_iosched_allow_bio_merge(rq, bio))
- return 0;
+ return false;
- return 1;
+ return true;
}
EXPORT_SYMBOL(elv_bio_merge_ok);
prev parent reply other threads:[~2016-07-02 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-02 10:17 [PATCH] block: do not merge requests without consulting with io scheduler kbuild test robot
2016-07-02 3:26 ` Tahsin Erdogan
2016-07-02 10:17 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160702101741.GA101651@lkp-sb04 \
--to=lkp@intel.com \
--cc=axboe@kernel.dk \
--cc=kbuild-all@01.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tahsin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox