From: Christoph Hellwig <hch@lst.de>
To: Ross Zwisler <zwisler@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, ming.lei@canonical.com,
Mike Christie <mchristi@redhat.com>,
Dave Chinner <david@fromorbit.com>,
linux-block@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: fix loop discard regression
Date: Fri, 5 Aug 2016 09:39:56 +0200 [thread overview]
Message-ID: <20160805073956.GA24229@lst.de> (raw)
In-Reply-To: <CAOxpaSXxmO8sB1D_03yu9H1CLeF+5iUWtRE7WLqddkqgSrCd_g@mail.gmail.com>
On Thu, Aug 04, 2016 at 12:55:26PM -0600, Ross Zwisler wrote:
> On Thu, Aug 4, 2016 at 8:09 AM, Christoph Hellwig <hch@lst.de> wrote:
> > The first patch fixes a regression where discard request were accidentally
> > marked as aio after the req_op conversion. This would have been mostly
> > harmless except for the god-awful parsing of request types later in the
> > actual I/O handler which turns them into a write, so the second patch
> > rewrites that handler using a proper switch statement as well.
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-block" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Tested-by: Ross Zwisler <ross.zwisler@linux.intel.com>
>
> Also, your 2nd patch is missing a signed-off-by.
Signed-off-by: Christoph Hellwig <hch@lst.de>
in case that Jens wants to bother with force-updating the tree.
next prev parent reply other threads:[~2016-08-05 7:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 14:09 fix loop discard regression Christoph Hellwig
2016-08-04 14:10 ` [PATCH 1/2] loop: don't try to use AIO for discards Christoph Hellwig
2016-08-04 14:24 ` Ming Lei
2016-08-04 14:10 ` [PATCH 2/2] loop: make do_req_filebacked more robust Christoph Hellwig
2016-08-04 14:35 ` fix loop discard regression Jens Axboe
2016-08-04 18:55 ` Ross Zwisler
2016-08-05 7:39 ` Christoph Hellwig [this message]
2016-08-05 13:51 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160805073956.GA24229@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=ming.lei@canonical.com \
--cc=zwisler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox