From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Jens Axboe <axboe@kernel.dk>, kbuild test robot <lkp@intel.com>,
Mike Christie <mchristi@redhat.com>,
kbuild-all@01.org, ross.zwisler@linux.intel.com,
linux-ext4@vger.kernel.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, minchan@kernel.org,
ngupta@vflare.org, vishal.l.verma@intel.com
Subject: Re: [PATCH 1/1] mm/block: convert rw_page users to bio op use
Date: Fri, 5 Aug 2016 00:53:35 -0700 [thread overview]
Message-ID: <20160805075335.GA20445@infradead.org> (raw)
In-Reply-To: <20160805021854.GV12670@dastard>
On Fri, Aug 05, 2016 at 12:18:55PM +1000, Dave Chinner wrote:
> Give this is being spread all over the kernel way outside the block
> layer and IO path, shouldn't this have some kind of namespace
> component to the name? i.e "req_op_is_write()"?
The READ/WRITE #defines alias to the request ops, so this helper is
rather global as well. Not that I like it, but it will take a while
to clean that up, including making various things __bitwise annotated
enums to get proper sparse type checking.
next prev parent reply other threads:[~2016-08-05 7:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 17:17 [PATCH 1/1] mm/block: convert rw_page users to bio op use Mike Christie
2016-08-04 17:50 ` kbuild test robot
2016-08-04 19:27 ` Jens Axboe
2016-08-04 19:59 ` Mike Christie
2016-08-04 20:15 ` Jens Axboe
2016-08-04 21:24 ` Mike Christie
2016-08-04 21:26 ` Jens Axboe
2016-08-05 2:18 ` Dave Chinner
2016-08-05 3:30 ` Mike Christie
2016-08-05 7:53 ` Christoph Hellwig [this message]
2016-08-04 18:46 ` Ross Zwisler
2016-08-04 18:51 ` Mike Christie
2016-08-05 7:57 ` Christoph Hellwig
2016-08-05 13:52 ` Jens Axboe
2016-08-05 14:09 ` Jens Axboe
2016-08-05 18:05 ` Mike Christie
2016-08-05 21:27 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160805075335.GA20445@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=kbuild-all@01.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mchristi@redhat.com \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=ross.zwisler@linux.intel.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).