From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 26 Aug 2016 10:05:01 -0400 From: Mike Snitzer To: Mikulas Patocka Cc: Jens Axboe , Eric Wheeler , Christoph Hellwig , dm-devel@redhat.com, johnstonj.public@codenest.com, linux-block@vger.kernel.org Subject: Re: dm-crypt: Fix error with too large bios Message-ID: <20160826140501.GA1061@redhat.com> References: <20160814000740.GA5317@redhat.com> <24746705-a3af-e634-e675-f2214b6cf356@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <24746705-a3af-e634-e675-f2214b6cf356@kernel.dk> List-ID: On Thu, Aug 25 2016 at 4:13pm -0400, Jens Axboe wrote: > On 08/25/2016 12:34 PM, Mikulas Patocka wrote: > > > >Device mapper can't split the bio in generic_make_request - it frees the > >md->queue->bio_split bioset, to save one kernel thread per device. Device > >mapper uses its own splitting mechanism. > > > >So what is the final decision? - should device mapper split the big bio or > >should bcache not submit big bios? > > > >I think splitting big bios in the device mapper is better - simply because > >it is much less code than reworking bcache to split bios internally. > > > >BTW. In the device mapper, we have a layer dm-io, that was created to work > >around bio size limitations - it accepts unlimited I/O request and splits > >it to several bios. When bio size limitations are gone, we could simplify > >dm-io too. > > The patch from Ming Lei was applied for 4.8 the other day. See linux-block commit: 4d70dca4eadf2f block: make sure a big bio is split into at most 256 bvecs http://git.kernel.dk/cgit/linux-block/commit/?h=for-linus&id=4d70dca4eadf2f95abe389116ac02b8439c2d16c