From: Vivek Goyal <vgoyal@redhat.com>
To: Paolo Valente <paolo.valente@unimore.it>
Cc: Shaohua Li <shli@fb.com>, Tejun Heo <tj@kernel.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@fb.com>,
Kernel-team@fb.com, jmoyer@redhat.com,
Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH V3 00/11] block-throttle: add .high limit
Date: Thu, 6 Oct 2016 13:49:43 -0400 [thread overview]
Message-ID: <20161006174943.GD17335@redhat.com> (raw)
In-Reply-To: <35D8ECB2-BE20-4A4E-9B93-951B0D5042C9@unimore.it>
On Thu, Oct 06, 2016 at 03:15:50PM +0200, Paolo Valente wrote:
[..]
> Shaohua, I have just realized that I have unconsciously defended a
> wrong argument. Although all the facts that I have reported are
> evidently true, I have argued as if the question was: "do we need to
> throw away throttling because there is proportional, or do we need to
> throw away proportional share because there is throttling?". This
> question is simply wrong, as I think consciously (sorry for my
> dissociated behavior :) ).
I was wondering about the same. We need both and both should be able
to work with fast devices of today using blk-mq interfaces without
much overhead.
>
> The best goal to achieve is to have both a good throttling mechanism,
> and a good proportional share scheduler. This goal would be valid if
> even if there was just one important scenario for each of the two
> approaches. The vulnus here is that you guys are constantly, and
> rightly, working on solutions to achieve and consolidate reasonable
> QoS guarantees, but an apparently very good proportional-share
> scheduler has been kept off for years. If you (or others) have good
> arguments to support this state of affairs, then this would probably
> be an important point to discuss.
Paolo, CFQ is legacy now and if we can come up with a proportional
IO mechanism which works reasonably well with fast devices using
blk-mq interfaces, that will be much more interesting.
Vivek
next prev parent reply other threads:[~2016-10-06 17:49 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 21:20 [PATCH V3 00/11] block-throttle: add .high limit Shaohua Li
2016-10-03 21:20 ` [PATCH v3 01/11] block-throttle: prepare support multiple limits Shaohua Li
2016-10-03 21:20 ` [PATCH v3 02/11] block-throttle: add .high interface Shaohua Li
2016-10-03 21:20 ` [PATCH v3 03/11] block-throttle: configure bps/iops limit for cgroup in high limit Shaohua Li
2016-10-03 21:20 ` [PATCH v3 04/11] block-throttle: add upgrade logic for LIMIT_HIGH state Shaohua Li
2016-10-03 21:20 ` [PATCH v3 05/11] block-throttle: add downgrade logic Shaohua Li
2016-10-03 21:20 ` [PATCH v3 06/11] blk-throttle: make sure expire time isn't too big Shaohua Li
2016-10-03 21:20 ` [PATCH v3 07/11] blk-throttle: make throtl_slice tunable Shaohua Li
2016-10-03 21:20 ` [PATCH v3 08/11] blk-throttle: detect completed idle cgroup Shaohua Li
2016-10-03 21:20 ` [PATCH v3 09/11] block-throttle: make bandwidth change smooth Shaohua Li
2016-10-03 21:20 ` [PATCH v3 10/11] block-throttle: add a simple idle detection Shaohua Li
2016-10-03 21:20 ` [PATCH v3 11/11] blk-throttle: ignore idle cgroup limit Shaohua Li
2016-10-04 13:28 ` [PATCH V3 00/11] block-throttle: add .high limit Vivek Goyal
2016-10-04 15:56 ` Tejun Heo
2016-10-04 16:22 ` Paolo Valente
2016-10-04 16:27 ` Tejun Heo
2016-10-04 17:01 ` Paolo Valente
2016-10-04 17:28 ` Shaohua Li
2016-10-04 17:43 ` Paolo Valente
2016-10-04 18:28 ` Shaohua Li
2016-10-04 19:49 ` Paolo Valente
2016-10-04 18:54 ` Tejun Heo
2016-10-04 19:02 ` Paolo Valente
2016-10-04 19:14 ` Tejun Heo
2016-10-04 19:29 ` Paolo Valente
2016-10-04 20:27 ` Tejun Heo
2016-10-05 12:37 ` Paolo Valente
2016-10-05 13:12 ` Vivek Goyal
2016-10-05 14:04 ` Paolo Valente
2016-10-05 14:49 ` Tejun Heo
2016-10-05 18:30 ` Shaohua Li
2016-10-05 19:08 ` Shaohua Li
2016-10-05 19:57 ` Paolo Valente
2016-10-05 20:36 ` Shaohua Li
2016-10-06 7:22 ` Paolo Valente
2016-10-05 19:47 ` Paolo Valente
2016-10-05 20:07 ` Paolo Valente
2016-10-05 20:46 ` Shaohua Li
2016-10-06 7:58 ` Paolo Valente
2016-10-06 13:15 ` Paolo Valente
2016-10-06 17:49 ` Vivek Goyal [this message]
2016-10-06 18:01 ` Paolo Valente
2016-10-06 18:32 ` Vivek Goyal
2016-10-06 20:51 ` Paolo Valente
2016-10-06 19:44 ` Mark Brown
2016-10-06 19:57 ` Shaohua Li
2016-10-06 22:24 ` Paolo Valente
[not found] ` <CACsaVZ+AqSXHTRdpdrQQp6PuynEPeB-5YOyweWsenjvuKsD12w@mail.gmail.com>
2016-10-09 1:15 ` Fwd: " Kyle Sanderson
2016-10-14 16:40 ` Tejun Heo
2016-10-14 17:13 ` Paolo Valente
2016-10-14 18:35 ` Tejun Heo
2016-10-16 19:02 ` Paolo Valente
2016-10-18 5:15 ` Kyle Sanderson
2016-10-06 8:04 ` Linus Walleij
2016-10-06 11:03 ` Mark Brown
2016-10-06 11:57 ` Austin S. Hemmelgarn
2016-10-06 12:50 ` Paolo Valente
2016-10-06 13:52 ` Austin S. Hemmelgarn
2016-10-06 15:05 ` Paolo Valente
2016-10-06 15:10 ` Austin S. Hemmelgarn
2016-10-04 18:12 ` Vivek Goyal
2016-10-04 18:50 ` Tejun Heo
2016-10-04 18:56 ` Paolo Valente
2016-10-04 17:08 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161006174943.GD17335@redhat.com \
--to=vgoyal@redhat.com \
--cc=Kernel-team@fb.com \
--cc=axboe@fb.com \
--cc=broonie@kernel.org \
--cc=jmoyer@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@unimore.it \
--cc=shli@fb.com \
--cc=tj@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).