From: Dan Carpenter <dan.carpenter@oracle.com>
To: tj@kernel.org
Cc: linux-block@vger.kernel.org
Subject: [bug report] blkcg: replace blkcg_policy->cpd_size with ->cpd_alloc/free_fn() methods
Date: Thu, 10 Nov 2016 16:34:26 +0300 [thread overview]
Message-ID: <20161110133426.GA30610@mwanda> (raw)
[ No idea why it's suddenly complaining about year old code - dan ]
Hello Tejun Heo,
The patch e4a9bde9589f: "blkcg: replace blkcg_policy->cpd_size with
->cpd_alloc/free_fn() methods" from Aug 18, 2015, leads to the
following static checker warning:
block/cfq-iosched.c:1589 cfq_cpd_alloc()
warn: use 'gfp' here instead of GFP_XXX?
block/cfq-iosched.c
1585 static struct blkcg_policy_data *cfq_cpd_alloc(gfp_t gfp)
1586 {
1587 struct cfq_group_data *cgd;
1588
1589 cgd = kzalloc(sizeof(*cgd), GFP_KERNEL);
It does feels weird to pass "gfp" and never use it.
1590 if (!cgd)
1591 return NULL;
1592 return &cgd->cpd;
1593 }
regards,
dan carpenter
reply other threads:[~2016-11-10 13:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110133426.GA30610@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox