* [bug report] blkcg: replace blkcg_policy->cpd_size with ->cpd_alloc/free_fn() methods
@ 2016-11-10 13:34 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2016-11-10 13:34 UTC (permalink / raw)
To: tj; +Cc: linux-block
[ No idea why it's suddenly complaining about year old code - dan ]
Hello Tejun Heo,
The patch e4a9bde9589f: "blkcg: replace blkcg_policy->cpd_size with
->cpd_alloc/free_fn() methods" from Aug 18, 2015, leads to the
following static checker warning:
block/cfq-iosched.c:1589 cfq_cpd_alloc()
warn: use 'gfp' here instead of GFP_XXX?
block/cfq-iosched.c
1585 static struct blkcg_policy_data *cfq_cpd_alloc(gfp_t gfp)
1586 {
1587 struct cfq_group_data *cgd;
1588
1589 cgd = kzalloc(sizeof(*cgd), GFP_KERNEL);
It does feels weird to pass "gfp" and never use it.
1590 if (!cgd)
1591 return NULL;
1592 return &cgd->cpd;
1593 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-11-10 13:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-10 13:34 [bug report] blkcg: replace blkcg_policy->cpd_size with ->cpd_alloc/free_fn() methods Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).