From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:44276 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbcKQVEt (ORCPT ); Thu, 17 Nov 2016 16:04:49 -0500 Date: Thu, 17 Nov 2016 13:04:48 -0800 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , linux-block@vger.kernel.org Subject: Re: [PATCHSET] Add support for simplified async direct-io Message-ID: <20161117210448.GA25566@infradead.org> References: <20161116163147.GA25038@infradead.org> <72b1725a-0363-d33e-f890-251b1ac88998@kernel.dk> <20161116171652.GA30008@infradead.org> <20161117125037.GB14814@infradead.org> <204d4a18-e5da-1806-433e-a3ff1b6ca575@kernel.dk> <87823f67-a2ec-e959-1a23-9ecf3d6fe6d4@kernel.dk> <20161117201749.GA15072@infradead.org> <721c8908-ea89-a2f4-0bfd-7243a9aa4c03@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <721c8908-ea89-a2f4-0bfd-7243a9aa4c03@kernel.dk> Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On Thu, Nov 17, 2016 at 01:30:12PM -0700, Jens Axboe wrote: > The last patch seems to have some issues: > > + bool is_sync = is_sync = is_sync_kiocb(iocb); > > and it's reverting part of the dio->is_sync that was part of my union > waiter/iocb change. So I'll leave that out for now, for those reasons. dio->is_sync isn't needed once the completion handlers are split. That beeing said I wonder how the above statement even compiled, there should just be a single assignment obviously. Did I mention that I don't like the split anyway? :)