From: Scott Bauer <scott.bauer@intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Keith Busch <keith.busch@intel.com>,
linux-block@vger.kernel.org, sagi@grimberg.me,
Rafael.Antognolli@intel.com, axboe@fb.com,
linux-nvme@lists.infradead.org, jonathan.derrick@intel.com,
j.naumann@fu-berlin.de
Subject: Re: [PATCH v2 2/4] block: Add Sed-opal library
Date: Fri, 9 Dec 2016 11:50:51 -0700 [thread overview]
Message-ID: <20161209185051.GB7865@sbauer-Z170X-UD5> (raw)
In-Reply-To: <20161209183034.GA28669@infradead.org>
On Fri, Dec 09, 2016 at 10:30:34AM -0800, Christoph Hellwig wrote:
> On Fri, Dec 09, 2016 at 10:45:30AM -0700, Scott Bauer wrote:
> > Now, with this in mind, it sort of makes sense to move this from
> > block/ back into lib/ and interface with the character dev. Instead
> > of passing around block_devices, we can pass around struct file *'s.
> >
>
> Even the character device is always backed by the queues, and I'd really
> not prefer to have a struct file here - that's not useful at all
> for in-kernel users.
Is your main concern that if an in-kernel user wants to use this functionality
they have to pass us a block device pointer, and may not be able to? Is that
why you wanted to pass a function pointer to the code because a driver/kernel-user
can probably always have that availiable to send to us?
next prev parent reply other threads:[~2016-12-09 18:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 21:51 [PATCH v2 0/4] SED OPAL Library Scott Bauer
2016-11-29 21:51 ` [PATCH v2 1/4] include: Add definitions for sed Scott Bauer
2016-11-29 21:52 ` [PATCH v2 2/4] block: Add Sed-opal library Scott Bauer
2016-11-30 18:13 ` Keith Busch
2016-11-30 18:09 ` Scott Bauer
2016-12-01 0:50 ` Keith Busch
2016-12-01 10:04 ` Christoph Hellwig
2016-12-01 17:53 ` Scott Bauer
2016-12-01 18:22 ` Keith Busch
2016-12-09 17:45 ` Scott Bauer
2016-12-09 18:30 ` Christoph Hellwig
2016-12-09 18:50 ` Scott Bauer [this message]
2016-11-29 21:52 ` [PATCH v2 3/4] nvme: Implement resume_from_suspend and sed block ioctl Scott Bauer
2016-12-01 0:50 ` Keith Busch
2016-11-29 21:52 ` [PATCH v2 4/4] Maintainers: Add Information for SED Opal library Scott Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161209185051.GB7865@sbauer-Z170X-UD5 \
--to=scott.bauer@intel.com \
--cc=Rafael.Antognolli@intel.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=j.naumann@fu-berlin.de \
--cc=jonathan.derrick@intel.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox