From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: Dan Williams <dan.j.williams@intel.com>,
axboe@fb.com, Andi Kleen <ak@linux.intel.com>,
Rabin Vincent <rabinv@axis.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
linux-block@vger.kernel.org, Jeff Moyer <jmoyer@redhat.com>,
Wei Fang <fangwei1@huawei.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] block: fix blk_get_backing_dev_info() crash, use bdev->bd_queue
Date: Tue, 10 Jan 2017 16:57:51 +0100 [thread overview]
Message-ID: <20170110155751.GA28921@lst.de> (raw)
In-Reply-To: <20170106102330.GB3533@quack2.suse.cz>
On Fri, Jan 06, 2017 at 11:23:30AM +0100, Jan Kara wrote:
> So what I think needs to be done is that we make backing_dev_info
> independently allocated structure with different lifetime rules to gendisk
> or request_queue - definitely I want it to live as long as block device
> inode exists. However it needs more thought what the exact lifetime rules
> will be.
Yes, moving the backing dev out (or keeping the request_queue memoery alive)
is something we need to do. And we need to look into the other half
of the backing_dev life time isssues - we need to make sure the name
and sysfs resources are released as soon as the devices goes away so that
we aren't going to run into reuse races.
prev parent reply other threads:[~2017-01-10 15:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 1:17 [PATCH] block: fix blk_get_backing_dev_info() crash, use bdev->bd_queue Dan Williams
2017-01-06 10:23 ` Jan Kara
2017-01-06 17:45 ` Dan Williams
2017-01-08 19:46 ` Jan Kara
2017-01-08 20:50 ` Dan Williams
2017-01-10 1:59 ` Dan Williams
2017-01-10 15:57 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110155751.GA28921@lst.de \
--to=hch@lst.de \
--cc=ak@linux.intel.com \
--cc=axboe@fb.com \
--cc=dan.j.williams@intel.com \
--cc=fangwei1@huawei.com \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rabinv@axis.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).