From: "hch@lst.de" <hch@lst.de>
To: Bart Van Assche <Bart.VanAssche@sandisk.com>
Cc: "hch@lst.de" <hch@lst.de>, "axboe@fb.com" <axboe@fb.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"snitzer@redhat.com" <snitzer@redhat.com>
Subject: Re: [PATCH 15/16] block: split scsi_request out of struct request
Date: Tue, 24 Jan 2017 09:09:06 +0100 [thread overview]
Message-ID: <20170124080906.GA17018@lst.de> (raw)
In-Reply-To: <1485217979.2825.20.camel@sandisk.com>
On Tue, Jan 24, 2017 at 12:33:13AM +0000, Bart Van Assche wrote:
> Do we perhaps need a check before the above memcpy() call whether or not
> sense == NULL?
Yes, probably. I didn't think of the case where the caller wouldn't
pass a sense buffer. Just curious, what's the callstack that caused
this?
next prev parent reply other threads:[~2017-01-24 8:09 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 15:29 split scsi passthrough fields out of struct request Christoph Hellwig
2017-01-23 15:29 ` [PATCH 01/16] block: fix elevator init check Christoph Hellwig
2017-01-24 7:02 ` Hannes Reinecke
2017-01-24 15:06 ` Jens Axboe
2017-01-24 15:10 ` Christoph Hellwig
2017-01-23 15:29 ` [PATCH 02/16] block: simplify blk_init_allocated_queue Christoph Hellwig
2017-01-24 7:37 ` Hannes Reinecke
2017-01-23 15:29 ` [PATCH 03/16] block: allow specifying size for extra command data Christoph Hellwig
2017-01-24 8:10 ` Hannes Reinecke
2017-01-23 15:29 ` [PATCH 04/16] dm: remove incomple BLOCK_PC support Christoph Hellwig
2017-01-24 8:22 ` Hannes Reinecke
2017-01-23 15:29 ` [PATCH 05/16] dm: always defer request allocation to the owner of the request_queue Christoph Hellwig
2017-01-24 8:29 ` Hannes Reinecke
2017-01-24 10:05 ` Mike Snitzer
2017-01-24 14:20 ` Christoph Hellwig
2017-01-24 16:39 ` Mike Snitzer
2017-01-24 19:52 ` Christoph Hellwig
2017-01-26 4:23 ` Junichi Nomura
2017-01-23 15:29 ` [PATCH 06/16] scsi_dh_rdac: switch to scsi_execute_req_flags() Christoph Hellwig
2017-01-23 15:29 ` [PATCH 07/16] scsi_dh_emc: " Christoph Hellwig
2017-01-23 15:29 ` [PATCH 08/16] scsi_dh_hp_sw: " Christoph Hellwig
2017-01-23 15:29 ` [PATCH 09/16] scsi: remove gfp_flags member in scsi_host_cmd_pool Christoph Hellwig
2017-01-24 12:08 ` Johannes Thumshirn
2017-01-23 15:29 ` [PATCH 10/16] scsi: respect unchecked_isa_dma for blk-mq Christoph Hellwig
2017-01-24 11:06 ` Hannes Reinecke
2017-01-23 15:29 ` [PATCH 11/16] scsi: remove scsi_cmd_dma_pool Christoph Hellwig
2017-01-24 11:07 ` Hannes Reinecke
2017-01-23 15:29 ` [PATCH 12/16] scsi: remove __scsi_alloc_queue Christoph Hellwig
2017-01-24 11:08 ` Hannes Reinecke
2017-01-24 11:24 ` Johannes Thumshirn
2017-01-23 15:29 ` [PATCH 13/16] scsi: allocate scsi_cmnd structures as part of struct request Christoph Hellwig
2017-01-24 12:57 ` Hannes Reinecke
2017-01-23 15:29 ` [PATCH 14/16] block/bsg: move queue creation into bsg_setup_queue Christoph Hellwig
2017-01-23 15:29 ` [PATCH 15/16] block: split scsi_request out of struct request Christoph Hellwig
2017-01-24 0:33 ` Bart Van Assche
2017-01-24 8:09 ` hch [this message]
2017-01-24 16:31 ` Bart Van Assche
2017-01-24 13:21 ` Hannes Reinecke
2017-01-26 19:12 ` Bart Van Assche
2017-01-26 19:37 ` Christoph Hellwig
2017-01-26 19:42 ` Jens Axboe
2017-01-23 15:29 ` [PATCH 16/16] block: don't assign cmd_flags in __blk_rq_prep_clone Christoph Hellwig
2017-01-24 13:22 ` Hannes Reinecke
2017-01-23 15:39 ` split scsi passthrough fields out of struct request Jens Axboe
2017-01-23 15:46 ` Christoph Hellwig
2017-01-24 0:30 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124080906.GA17018@lst.de \
--to=hch@lst.de \
--cc=Bart.VanAssche@sandisk.com \
--cc=axboe@fb.com \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).