From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 27 Jan 2017 17:42:33 +0100 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , Mike Snitzer , Junichi Nomura , linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-raid@vger.kernel.org, dm-devel@redhat.com Subject: Re: split scsi passthrough fields out of struct request V2 Message-ID: <20170127164233.GA17438@lst.de> References: <1485365126-23210-1-git-send-email-hch@lst.de> <20170127161114.GA501@kernel.dk> <20170127161718.GA16911@lst.de> <775aff8d-6bcc-9cc5-cfa3-dd1c157c95c5@fb.com> <20170127162316.GA17059@lst.de> <195e1638-7d85-0618-0101-5cfff34b91e9@fb.com> <20170127163450.GA17311@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-ID: On Fri, Jan 27, 2017 at 09:38:40AM -0700, Jens Axboe wrote: > > Ok, I'll repost what I have right now, which is on top of a merge > > of your block/for-4.11/next and your for-next from this morning > > my time. > > Perfect. At least I tried, looks like the mail server is overloaded and crapped out three mails into it. For now there is a git tree here: http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/block-pc-refactor > > > Btw, I disagred with your patch to use op_is_flush in > > generic_make_request_checks - given that we clear these flags just > > below I think using the helper obsfucates what's really going on. > > Why? It's the exact same check. The ugly part is the fact that > we strip the flags later on, imho. But before it was pretty obvious that it clears exactly the flags checked two lines earlier. Now it's not as obvious.