From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hch@lst.de>
Date: Fri, 3 Feb 2017 09:26:06 +0100
From: Christoph Hellwig <hch@lst.de>
To: Jason Wang <jasowang@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, mst@redhat.com, axboe@kernel.dk,
	pbonzini@redhat.com, virtualization@lists.linux-foundation.org,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/9] virtio_pci: use shared interrupts for virtqueues
Message-ID: <20170203082606.GB26800@lst.de>
References: <1485504997-17584-1-git-send-email-hch@lst.de> <1485504997-17584-3-git-send-email-hch@lst.de> <da34883b-1069-2cfc-aaa3-6aaf3ee0ebf2@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
In-Reply-To: <da34883b-1069-2cfc-aaa3-6aaf3ee0ebf2@redhat.com>
List-ID: <linux-block@vger.kernel.org>

On Fri, Feb 03, 2017 at 03:54:54PM +0800, Jason Wang wrote:
> On 2017年01月27日 16:16, Christoph Hellwig wrote:
>> +		snprintf(vp_dev->msix_names[i + 1],
>> +			 sizeof(*vp_dev->msix_names), "%s-%s",
>>   			 dev_name(&vp_dev->vdev.dev), names[i]);
>>   		err = request_irq(pci_irq_vector(vp_dev->pci_dev, msix_vec),
>> -				  vring_interrupt, 0,
>> -				  vp_dev->msix_names[msix_vec],
>> -				  vqs[i]);
>> +				  vring_interrupt, IRQF_SHARED,
>> +				  vp_dev->msix_names[i + 1], vqs[i]);
>
> Do we need to check per_vq_vectors before dereferencing msix_names[i + 1] ?

No, we need to allocate the array larger in that case as want proper
names for the interrupts.