From: Omar Sandoval <osandov@osandov.com>
To: Jens Axboe <axboe@fb.com>
Cc: linux-block@vger.kernel.org, paolo.valente@linaro.org
Subject: Re: [PATCH 1/2] blk-merge: return the merged request
Date: Fri, 3 Feb 2017 08:42:29 -0800 [thread overview]
Message-ID: <20170203164229.GA26515@vader> (raw)
In-Reply-To: <1486051573-13445-2-git-send-email-axboe@fb.com>
On Thu, Feb 02, 2017 at 09:06:12AM -0700, Jens Axboe wrote:
> When we attempt to merge request-to-request, we return a 0/1 if we
> ended up merging or not. Change that to return the pointer to the
> request that we freed. We will use this to move the freeing of
> that request out of the merge logic, so that callers can drop
> locks before freeing the request.
>
> There should be no functional changes in this patch.
Reviewed-by: Omar Sandoval <osandov@fb.com>
> Signed-off-by: Jens Axboe <axboe@fb.com>
> ---
> block/blk-merge.c | 31 ++++++++++++++++---------------
> block/blk.h | 4 ++--
> 2 files changed, 18 insertions(+), 17 deletions(-)
next prev parent reply other threads:[~2017-02-03 16:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 16:06 [PATCH 0/2] blk-mq-sched: fix put_rq_private() lock inconsistency Jens Axboe
2017-02-02 16:06 ` [PATCH 1/2] blk-merge: return the merged request Jens Axboe
2017-02-03 16:42 ` Omar Sandoval [this message]
2017-02-02 16:06 ` [PATCH 2/2] block: free merged request in the caller Jens Axboe
2017-02-03 16:44 ` Omar Sandoval
2017-02-07 17:35 ` Paolo Valente
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203164229.GA26515@vader \
--to=osandov@osandov.com \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).