From: Omar Sandoval <osandov@osandov.com>
To: Jens Axboe <axboe@fb.com>, linux-block@vger.kernel.org
Cc: kernel-team@fb.com
Subject: Re: [PATCH] blk-mq-sched: separate mark hctx and queue restart operations
Date: Fri, 3 Feb 2017 15:54:15 -0800 [thread overview]
Message-ID: <20170203235415.GA2686@vader.DHCP.thefacebook.com> (raw)
In-Reply-To: <0e041bc5f968fd15d86f1a89789c30ea82dd96ab.1486150202.git.osandov@fb.com>
On Fri, Feb 03, 2017 at 11:35:58AM -0800, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> In blk_mq_sched_dispatch_requests(), we call blk_mq_sched_mark_restart()
> after we dispatch requests left over on our hardware queue dispatch
> list. This is so we'll go back and dispatch requests from the scheduler.
> In this case, it's only necessary to restart the hardware queue that we
> are running; there's no reason to run other hardware queues just because
> we are using shared tags.
>
> So, split out blk_mq_sched_mark_restart() into two operations: the "all"
> variant is for when we really need to mark the request queue as needing
> a restart, and we'll keep the original for just the hardware queue.
>
> Signed-off-by: Omar Sandoval <osandov@fb.com>
> ---
> Based on block/for-next. There might be a better name for this.
>
> block/blk-mq-sched.h | 15 +++++++++++++++
> block/blk-mq.c | 2 +-
> 2 files changed, 16 insertions(+), 1 deletion(-)
Actually, I think I want to do this slightly differently, ignore this
for now.
prev parent reply other threads:[~2017-02-03 23:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 19:35 [PATCH] blk-mq-sched: separate mark hctx and queue restart operations Omar Sandoval
2017-02-03 23:54 ` Omar Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203235415.GA2686@vader.DHCP.thefacebook.com \
--to=osandov@osandov.com \
--cc=axboe@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox