From: Wouter Verhelst <w@uter.be>
To: Josef Bacik <jbacik@fb.com>
Cc: Alex Bligh <alex@alex.org.uk>,
axboe@kernel.dk, linux-block@vger.kernel.org, kernel-team@fb.com,
"nbd-general@lists.sourceforge.net"
<nbd-general@lists.sourceforge.net>
Subject: Re: [Nbd] [PATCH] nbd: set the logical and physical blocksize properly
Date: Sat, 11 Feb 2017 12:43:56 +0100 [thread overview]
Message-ID: <20170211114356.qr2atsx4ewcjfbes@grep.be> (raw)
In-Reply-To: <1486763262.4094.12.camel@fb.com>
On Fri, Feb 10, 2017 at 04:47:42PM -0500, Josef Bacik wrote:
> On Fri, 2017-02-10 at 21:07 +0100, Alex Bligh wrote:
> > >
> > > On 10 Feb 2017, at 19:06, Josef Bacik <jbacik@fb.com> wrote:
> > >
> > > We noticed when trying to do O_DIRECT to an export on the server
> > > side
> > > that we were getting requests smaller than the 4k sectorsize of the
> > > device.��This is because the client isn't setting the logical and
> > > physical blocksizes properly for the underlying device.��Fix this
> > > up by
> > > setting the queue blocksizes and then calling bd_set_size.
> > Interesting. Some input into the info extension (re blocksizes) would
> > definitely be appreciated.
> >
>
> What do you mean? �Right now the client is just calling�NBD_SET_BLKSIZE
> with 4k blocksize since all of our devices are 4k drives. �Thanks,
He's talking about
<https://github.com/NetworkBlockDevice/nbd/blob/extension-info/doc/proto.md#block-size-constraints>,
which is a protocol extension that hasn't been implemented yet but would
be relevant to this patch.
--
< ron> I mean, the main *practical* problem with C++, is there's like a dozen
people in the world who think they really understand all of its rules,
and pretty much all of them are just lying to themselves too.
-- #debian-devel, OFTC, 2016-02-12
next prev parent reply other threads:[~2017-02-11 11:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 18:06 [PATCH] nbd: set the logical and physical blocksize properly Josef Bacik
2017-02-10 20:07 ` [Nbd] " Alex Bligh
2017-02-10 21:47 ` Josef Bacik
2017-02-11 11:43 ` Wouter Verhelst [this message]
2017-02-11 16:13 ` Alex Bligh
2017-02-13 15:39 ` [PATCH V2] " Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170211114356.qr2atsx4ewcjfbes@grep.be \
--to=w@uter.be \
--cc=alex@alex.org.uk \
--cc=axboe@kernel.dk \
--cc=jbacik@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=nbd-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox