From: Christoph Hellwig <hch@infradead.org>
To: Scott Bauer <scott.bauer@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Keith Busch <keith.busch@intel.com>,
linux-block@vger.kernel.org,
Jonathan Derrick <jonathan.derrick@intel.com>,
Jens Axboe <axboe@fb.com>
Subject: Re: [PATCH] opal: Use empty structure when not defined
Date: Thu, 16 Feb 2017 12:07:08 -0800 [thread overview]
Message-ID: <20170216200708.GA16140@infradead.org> (raw)
In-Reply-To: <20170216184528.GA3899@sbauer-Z170X-UD5>
On Thu, Feb 16, 2017 at 11:45:29AM -0700, Scott Bauer wrote:
> > + if (check_opal_support(dev) < 0) {
> > pr_warn("Opal is not supported on this device\n");
> > - opal_dev->initialized = true;
> > + kfree(dev);
> > + return NULL;
>
> We're going to have to change this check_opal_support to be != 0 instead of < 0.
Yes. And we should simply turn all these printk into pr_debug anway -
not having OPAL is a prefectly fine condition, no need to spam the log
for it.
And btw, I think we should check for bit 0 in OACS before ever doing
a security send / receive.
next prev parent reply other threads:[~2017-02-16 20:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 0:16 [PATCH] opal: Use empty structure when not defined Keith Busch
2017-02-16 2:01 ` Scott Bauer
2017-02-16 7:58 ` Christoph Hellwig
2017-02-16 17:18 ` Jon Derrick
2017-02-16 17:21 ` Christoph Hellwig
2017-02-16 17:37 ` Scott Bauer
2017-02-16 17:39 ` Scott Bauer
2017-02-16 18:45 ` Scott Bauer
2017-02-16 20:07 ` Christoph Hellwig [this message]
2017-02-16 20:52 ` Scott Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170216200708.GA16140@infradead.org \
--to=hch@infradead.org \
--cc=axboe@fb.com \
--cc=jonathan.derrick@intel.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=scott.bauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).