Linux block layer
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: linux-block <linux-block@vger.kernel.org>,
	Omar Sandoval <osandov@fb.com>, Jens Axboe <axboe@fb.com>,
	LKP <lkp@01.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [blk_mq_register_hctx] 29dee3c03a WARNING: CPU: 0 PID: 5 at lib/refcount.c:114 refcount_inc
Date: Tue, 28 Feb 2017 09:17:11 +0100	[thread overview]
Message-ID: <20170228081711.GW6515@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20170228041117.hbqqyczf5bnypqmc@wfg-t540p.sh.intel.com>

On Tue, Feb 28, 2017 at 12:11:17PM +0800, Fengguang Wu wrote:
> Hello,
> 
> FYI, an old blk_mq bug triggers new warnings on this commit. It's very
> reproducible and you may try the attached reproduce-* script.

> [    4.447772] kobject (ffff88001c041f10): tried to init an initialized object, something is seriously wrong.
> [    4.453395] CPU: 0 PID: 5 Comm: kworker/u2:0 Not tainted 4.10.0-01216-g29dee3c #2
> [    4.455534] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.3-20161025_171302-gandalf 04/01/2014
> [    4.458252] Workqueue: events_unbound async_run_entry_fn
> [    4.459708] Call Trace:
> [    4.460611]  dump_stack+0x19/0x27
> [    4.461652]  kobject_init+0xda/0xf0
> [    4.462731]  blk_mq_register_dev+0x31/0x150
> [    4.463990]  blk_register_queue+0x205/0x250
> [    4.465217]  device_add_disk+0x1ab/0x710
> [    4.466384]  sd_probe_async+0x11c/0x1e0
> [    4.467544]  async_run_entry_fn+0xbd/0x220
> [    4.468760]  process_one_work+0x4a7/0x990
> [    4.469938]  ? process_one_work+0x348/0x990
> [    4.471168]  worker_thread+0x342/0x8a0
> [    4.472300]  ? process_one_work+0x990/0x990
> [    4.473540]  kthread+0x188/0x190
> [    4.474557]  ? kthread_create_on_node+0x40/0x40
> [    4.475850]  ret_from_fork+0x31/0x40

So this was pre-existing wreckage? If so, that needs to be sorted first.
Because if the kobject stuff is broken, there's no way the refcount
stuff can begin to work.

  parent reply	other threads:[~2017-02-28  8:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170228041117.hbqqyczf5bnypqmc@wfg-t540p.sh.intel.com>
2017-02-28  7:48 ` [blk_mq_register_hctx] 29dee3c03a WARNING: CPU: 0 PID: 5 at lib/refcount.c:114 refcount_inc Peter Zijlstra
2017-02-28  8:17 ` Peter Zijlstra [this message]
2017-02-28  8:35   ` Fengguang Wu
2017-02-28  8:52     ` Omar Sandoval
2017-02-28  8:38   ` Peter Zijlstra
2017-02-28  9:45     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170228081711.GW6515@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=axboe@fb.com \
    --cc=fengguang.wu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-block@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=osandov@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox