From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Sender: Tejun Heo Date: Tue, 28 Feb 2017 11:14:38 -0500 From: Tejun Heo To: Jan Kara Cc: Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , Dan Williams , Thiago Jung Bauermann , Lekshmi Pillai , NeilBrown , Omar Sandoval Subject: Re: [PATCH 07/13] bdi: Move removal from bdi->wb_list into wb_shutdown() Message-ID: <20170228161438.GC15287@htj.duckdns.org> References: <20170221170958.21845-1-jack@suse.cz> <20170221170958.21845-8-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170221170958.21845-8-jack@suse.cz> List-ID: On Tue, Feb 21, 2017 at 06:09:52PM +0100, Jan Kara wrote: > Currently the removal from bdi->wb_list happens directly in > cgwb_release_workfn(). Move it to wb_shutdown() which is functionally > equivalent and more logical (the list gets only used for distributing > writeback works among bdi_writeback structures). It will also allow us > to simplify writeback shutdown in cgwb_bdi_destroy(). > > Signed-off-by: Jan Kara Acked-by: Tejun Heo Thanks. -- tejun