From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([65.50.211.133]:53267 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752168AbdCAPhN (ORCPT ); Wed, 1 Mar 2017 10:37:13 -0500 Date: Wed, 1 Mar 2017 07:36:48 -0800 From: Christoph Hellwig To: Goldwyn Rodrigues Cc: jack@suse.com, hch@infradead.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, Goldwyn Rodrigues Subject: Re: [PATCH 1/8] nowait aio: Introduce IOCB_FLAG_NOWAIT Message-ID: <20170301153647.GA30631@infradead.org> References: <20170228233610.25456-1-rgoldwyn@suse.de> <20170228233610.25456-2-rgoldwyn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170228233610.25456-2-rgoldwyn@suse.de> Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On Tue, Feb 28, 2017 at 05:36:03PM -0600, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues > > This flag informs kernel to bail out if an AIO request will block > for reasons such as file allocations, or a writeback triggered, > or would block while allocating requests while performing > direct I/O. > > IOCB_FLAG_NOWAIT is translated to IOCB_NOWAIT for > iocb->ki_flags. Given that we aren't validating aio_flags in older kernels we can't just add this flag as it will be a no-op in older kernels. I think we will have to add IOCB_CMD_PREADV2/IOCB_CMD_WRITEV2 opcodes that properly validate all reserved fields or flags first. Once we do that I'd really prefer to use the same flags values as preadv2/pwritev2 so that we'll only need one set of flags over sync/async read/write ops.