From: Tejun Heo <tj@kernel.org>
To: Tahsin Erdogan <tahsin@google.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] blkcg: allocate struct blkcg_gq outside request queue spinlock
Date: Fri, 3 Mar 2017 11:23:25 -0800 [thread overview]
Message-ID: <20170303192325.GB22962@wtj.duckdns.org> (raw)
In-Reply-To: <CAAeU0aO5hD8DHKOyGmskK5icCqf5U8hdMEZSfn6eLcHeL-YH7g@mail.gmail.com>
Hello, Tahsin.
On Thu, Mar 02, 2017 at 02:33:11PM -0800, Tahsin Erdogan wrote:
> > And let blkg_create() verify these conditions after releasing and
> > regrabbing the lock.
> >
> > This also means that the init path can simply pass in GFP_KERNEL.
>
> I tried that approach, but I encountered two issues that complicate things:
>
> 1) Pushing down blk_queue_bypass(q) check in blkg_create() doesn't
> quite work because when blkcg_init_queue() calls blkg_create(), the
> queue is still in bypassing mode.
>
> 2) Pushing down blkcg_policy_enabled() doesn't work well either,
> because blkcg_init_queue() doesn't have a policy to pass down. We
> could let it pass a NULL parameter but that would make blkg_create
> more ugly.
I see. It kinda really bothers me that we'll have two different modes
for non-atomic allocations. Can't we bind both to the policy
parameter? Skip the checks if policy is NULL?
Thanks.
--
tejun
next prev parent reply other threads:[~2017-03-03 19:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 2:49 [PATCH] blkcg: allocate struct blkcg_gq outside request queue spinlock Tahsin Erdogan
2017-02-28 22:47 ` Tejun Heo
2017-02-28 23:51 ` Tahsin Erdogan
2017-03-01 16:55 ` Tejun Heo
2017-03-01 23:43 ` [PATCH v2] " Tahsin Erdogan
2017-03-01 23:49 ` Tahsin Erdogan
2017-03-02 19:32 ` Tejun Heo
2017-03-02 22:33 ` Tahsin Erdogan
2017-03-03 19:23 ` Tejun Heo [this message]
2017-03-04 1:40 ` [PATCH v3] " Tahsin Erdogan
2017-03-04 19:23 ` Tejun Heo
2017-03-05 14:12 ` [PATCH v4] " Tahsin Erdogan
2017-03-05 14:24 ` Tahsin Erdogan
2017-03-06 20:03 ` Tejun Heo
2017-03-09 8:05 ` [PATCH v5] " Tahsin Erdogan
2017-03-09 18:27 ` Tejun Heo
2017-03-11 22:42 ` Jens Axboe
2017-03-11 22:52 ` Jens Axboe
2017-03-12 4:35 ` Tahsin Erdogan
2017-03-13 14:32 ` Jens Axboe
2017-03-13 16:17 ` Tahsin Erdogan
2017-03-24 21:56 ` [PATCH] " Tahsin Erdogan
2017-03-24 22:04 ` Jens Axboe
2017-03-28 21:53 ` Tejun Heo
2017-03-28 21:59 ` [PATCH v5] " Jens Axboe
2017-03-28 22:01 ` Tahsin Erdogan
2017-03-09 5:25 ` [lkp-robot] [blkcg] ad63af3cb7: BUG:sleeping_function_called_from_invalid_context_at_mm/slab.h kernel test robot
2017-03-09 7:59 ` Tahsin Erdogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170303192325.GB22962@wtj.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=tahsin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox