From: Wouter Verhelst <w@uter.be>
To: Josef Bacik <jbacik@fb.com>
Cc: axboe@kernel.dk, nbd-general@lists.sourceforge.net,
linux-block@vger.kernel.org, kernel-team@fb.com
Subject: Re: [Nbd] [PATCH 6/6] nbd: add a basic netlink interface
Date: Wed, 8 Mar 2017 11:07:04 +0100 [thread overview]
Message-ID: <20170308100704.xdxuhlpsttigfreq@grep.be> (raw)
In-Reply-To: <1488301031-3199-7-git-send-email-jbacik@fb.com>
On Tue, Feb 28, 2017 at 11:57:11AM -0500, Josef Bacik wrote:
> The existing ioctl interface for configuring NBD devices is a bit
> cumbersome and hard to extend. The other problem is we leave a
> userspace app sitting in it's syscall until the device disconnects,
> which is less than ideal.
True.
On the other hand, it has the advantage that you leave a userspace app
sitting around until the device disconnects, which allows for some form
of recovery in case you're doing root-on-NBD and the server has a
hiccup. Don't underestimate the advantage of that.
(of course, that requires that the return value of NBD_DO_IT makes a
difference between "unexpected connection drop" and "we sent
NBD_CMD_DISC", but that's a different matter entirely)
--
< ron> I mean, the main *practical* problem with C++, is there's like a dozen
people in the world who think they really understand all of its rules,
and pretty much all of them are just lying to themselves too.
-- #debian-devel, OFTC, 2016-02-12
next prev parent reply other threads:[~2017-03-08 10:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 16:57 [PATCH 0/6] Lots of NBD fixes and enhancements Josef Bacik
2017-02-28 16:57 ` [PATCH 1/6] nbd: handle single path failures gracefully Josef Bacik
2017-02-28 16:57 ` [PATCH 2/6] nbd: ref count the nbd device Josef Bacik
2017-02-28 16:57 ` [PATCH 3/6] nbd: stop using the bdev everywhere Josef Bacik
2017-02-28 16:57 ` [PATCH 4/6] nbd: set queue timeout properly Josef Bacik
2017-02-28 16:57 ` [PATCH 5/6] nbd: handle ERESTARTSYS properly Josef Bacik
2017-02-28 16:57 ` [PATCH 6/6] nbd: add a basic netlink interface Josef Bacik
2017-03-08 10:07 ` Wouter Verhelst [this message]
2017-03-08 14:56 ` [Nbd] " Josef Bacik
2017-03-08 20:44 ` Wouter Verhelst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170308100704.xdxuhlpsttigfreq@grep.be \
--to=w@uter.be \
--cc=axboe@kernel.dk \
--cc=jbacik@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=nbd-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox