From: Omar Sandoval <osandov@osandov.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@fb.com>, Vivek Goyal <vgoyal@redhat.com>,
linux-block@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 0/6] block: convert remaining drivers which share a request queue
Date: Mon, 27 Mar 2017 23:33:59 -0700 [thread overview]
Message-ID: <20170328063359.GA14159@vader> (raw)
In-Reply-To: <20170328063319.GB11751@infradead.org>
On Mon, Mar 27, 2017 at 11:33:19PM -0700, Christoph Hellwig wrote:
> On Mon, Mar 27, 2017 at 11:28:41PM -0700, Omar Sandoval wrote:
> > From: Omar Sandoval <osandov@fb.com>
> >
> > This is clearly the pinnacle of my career: converting all remaining
> > block drivers which share a request queue across gendisks to use a
> > separate request queue per gendisk. These are all compile tested (but
> > the last two platform-specific ones involved hacking the Kconfig and
> > commenting out a bunch of arch-dependent code to get the rest to
> > compile), no runtime testing at all.
> >
> > Let me know if I missed any. Even better, let me know if we can just
> > delete some of these entirely.
>
> Weren't the floppy drivers the prime example of shared request queue?
> I haven't looked at any of them for a while, so I'm not sure if that's
> still the case.
Those have all been fixed up, besides the swim one in this series:
786029ff810f ("amiga floppy: Stop sharing request queue across multiple gendisks")
639e2f2aa76e ("atari floppy: Stop sharing request queue across multiple gendisks")
488211844e0c ("floppy: switch to one queue per drive instead of sharing a queue")
next prev parent reply other threads:[~2017-03-28 6:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 6:28 [PATCH 0/6] block: convert remaining drivers which share a request queue Omar Sandoval
2017-03-28 6:28 ` [PATCH 1/6] hd: stop sharing request queue across multiple gendisks Omar Sandoval
2017-03-28 6:32 ` Christoph Hellwig
2017-03-28 6:28 ` [PATCH 2/6] parport/pd: " Omar Sandoval
2017-03-28 6:28 ` [PATCH 3/6] parport/pcd: " Omar Sandoval
2017-03-28 6:28 ` [PATCH 4/6] parport/pf: " Omar Sandoval
2017-03-28 6:28 ` [PATCH 5/6] swim: " Omar Sandoval
2017-03-28 6:28 ` [PATCH 6/6] jsflash: " Omar Sandoval
2017-03-28 6:33 ` [PATCH 0/6] block: convert remaining drivers which share a request queue Christoph Hellwig
2017-03-28 6:33 ` Omar Sandoval [this message]
2017-03-28 21:07 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328063359.GA14159@vader \
--to=osandov@osandov.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).