From: Omar Sandoval <osandov@osandov.com>
To: Keith Busch <keith.busch@intel.com>
Cc: Jens Axboe <axboe@fb.com>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Josef Bacik <jbacik@fb.com>,
kernel-team@fb.com
Subject: Re: [PATCH] blk-mq: remap queues when adding/removing hardware queues
Date: Fri, 31 Mar 2017 13:30:15 -0700 [thread overview]
Message-ID: <20170331203015.GA11462@vader> (raw)
In-Reply-To: <20170331203044.GL20181@localhost.localdomain>
On Fri, Mar 31, 2017 at 04:30:44PM -0400, Keith Busch wrote:
> On Fri, Mar 31, 2017 at 11:59:24AM -0700, Omar Sandoval wrote:
> > @@ -2629,11 +2639,12 @@ void blk_mq_update_nr_hw_queues(struct blk_mq_tag_set *set, int nr_hw_queues)
> > set->nr_hw_queues = nr_hw_queues;
> > list_for_each_entry(q, &set->tag_list, tag_set_list) {
> > blk_mq_realloc_hw_ctxs(set, q);
> > - blk_mq_queue_reinit(q, cpu_online_mask);
> > + blk_mq_queue_reinit(q, cpu_online_mask, true);
>
> I think you want to call blk_mq_update_queue_map directly outside this
> loop rather than for each queue through blk_mq_queue_reinit. We only
> need to map the queues once per tagset rather than per queue.
Right, thanks, I'll do that. I figure you're the person to ask,
nvme_add_dev() does want the remap to happen, right?
next prev parent reply other threads:[~2017-03-31 20:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 18:59 [PATCH] blk-mq: remap queues when adding/removing hardware queues Omar Sandoval
2017-03-31 19:01 ` Omar Sandoval
2017-03-31 20:30 ` Keith Busch
2017-03-31 20:30 ` Omar Sandoval [this message]
2017-03-31 20:44 ` Keith Busch
2017-03-31 20:43 ` [PATCH v2] " Omar Sandoval
2017-03-31 20:46 ` Omar Sandoval
2017-03-31 20:48 ` [PATCH v3] " Omar Sandoval
2017-03-31 21:09 ` Keith Busch
2017-04-04 6:24 ` Christoph Hellwig
2017-04-05 12:01 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331203015.GA11462@vader \
--to=osandov@osandov.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=jbacik@fb.com \
--cc=keith.busch@intel.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox