From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 6 Apr 2017 20:47:32 +0200 From: Johannes Thumshirn To: Christoph Hellwig Cc: Jens Axboe , Josef Bacik , James Smart , Konrad Rzeszutek Wilk , Roger Pau =?iso-8859-1?Q?Monn=E9?= , linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, dm-devel@redhat.com Subject: Re: [PATCH 04/25] nvme: split nvme status from block req->errors Message-ID: <20170406184730.GB8673@linux-x5ow.site> References: <20170406153944.10058-1-hch@lst.de> <20170406153944.10058-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: <20170406153944.10058-5-hch@lst.de> List-ID: On Thu, Apr 06, 2017 at 05:39:23PM +0200, Christoph Hellwig wrote: > We want our own clearly defined error field for NVMe passthrough commands, > and the request errors field is going away in its current form. > > Just store the status and result field in the nvme_request field from > hardirq completion context (using a new helper) and then generate a > Linux errno for the block layer only when we actually need it. > > Because we can't overload the status value with a negative error code > for cancelled command we now have a flags filed in struct nvme_request > that contains a bit for this condition. > > Signed-off-by: Christoph Hellwig > --- Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg GF: Felix Imend�rffer, Jane Smithard, Graham Norton HRB 21284 (AG N�rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850