From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: <linux-block@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
"Bart Van Assche" <bart.vanassche@sandisk.com>
Subject: [PATCH v4 0/6] Avoid that scsi-mq and dm-mq queue processing stalls sporadically
Date: Fri, 7 Apr 2017 11:16:48 -0700 [thread overview]
Message-ID: <20170407181654.27836-1-bart.vanassche@sandisk.com> (raw)
Hello Jens,
The six patches in this patch series fix the queue lockup I reported
recently on the linux-block mailing list. Please consider these patches
for inclusion in the upstream kernel.
Thanks,
Bart.
Changes between v3 and v4:
- Addressed the review comments on version three of this series about the
patch that makes it safe to use RCU to iterate over .tag_list and also
about the runtime performance and use of short variable names in patch 2/5.
- Clarified the description of the patch that fixes the scsi-mq stall.
- Added a patch to fix a dm-mq queue stall.
Changes between v2 and v3:
- Removed the blk_mq_ops.restart_hctx function pointer again.
- Modified blk_mq_sched_restart_queues() such that only a single hardware
queue is restarted instead of multiple if hardware queues are shared.
- Introduced a new function in the block layer, namely
blk_mq_delay_run_hw_queue().
Changes between v1 and v2:
- Reworked scsi_restart_queues() such that it no longer takes the SCSI
host lock.
- Added two patches - one for exporting blk_mq_sched_restart_hctx() and
another one to make iterating with RCU over blk_mq_tag_set.tag_list safe.
Bart Van Assche (6):
blk-mq: Make it safe to use RCU to iterate over
blk_mq_tag_set.tag_list
blk-mq: Restart a single queue if tag sets are shared
blk-mq: Clarify comments in blk_mq_dispatch_rq_list()
blk-mq: Introduce blk_mq_delay_run_hw_queue()
scsi: Avoid that SCSI queues get stuck
dm rq: Avoid that request processing stalls sporadically
block/blk-mq-sched.c | 63 +++++++++++++++++++++++++++++++++++-------
block/blk-mq-sched.h | 16 +----------
block/blk-mq.c | 73 +++++++++++++++++++++++++++++++++++++++----------
drivers/md/dm-rq.c | 1 +
drivers/scsi/scsi_lib.c | 6 ++--
include/linux/blk-mq.h | 2 ++
include/linux/blkdev.h | 1 -
7 files changed, 118 insertions(+), 44 deletions(-)
--
2.12.0
next reply other threads:[~2017-04-07 18:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 18:16 Bart Van Assche [this message]
2017-04-07 18:16 ` [PATCH v4 1/6] blk-mq: Make it safe to use RCU to iterate over blk_mq_tag_set.tag_list Bart Van Assche
2017-04-10 7:10 ` Christoph Hellwig
2017-04-07 18:16 ` [PATCH v4 2/6] blk-mq: Restart a single queue if tag sets are shared Bart Van Assche
2017-04-10 7:11 ` Christoph Hellwig
2017-04-07 18:16 ` [PATCH v4 3/6] blk-mq: Clarify comments in blk_mq_dispatch_rq_list() Bart Van Assche
2017-04-10 7:11 ` Christoph Hellwig
2017-04-07 18:16 ` [PATCH v4 4/6] blk-mq: Introduce blk_mq_delay_run_hw_queue() Bart Van Assche
2017-04-10 7:12 ` Christoph Hellwig
2017-04-10 15:02 ` Jens Axboe
2017-04-07 18:16 ` [PATCH v4 5/6] scsi: Avoid that SCSI queues get stuck Bart Van Assche
2017-04-10 7:12 ` Christoph Hellwig
2017-04-07 18:16 ` [PATCH v4 6/6] dm rq: Avoid that request processing stalls sporadically Bart Van Assche
2017-04-11 16:09 ` Mike Snitzer
2017-04-11 16:26 ` Bart Van Assche
2017-04-11 17:47 ` Mike Snitzer
2017-04-11 17:51 ` Bart Van Assche
2017-04-11 18:03 ` Mike Snitzer
2017-04-11 18:18 ` Bart Van Assche
2017-04-12 3:42 ` Ming Lei
2017-04-12 18:38 ` Bart Van Assche
2017-04-13 2:20 ` Ming Lei
2017-04-13 16:59 ` Bart Van Assche
2017-04-14 1:13 ` Ming Lei
2017-04-14 17:12 ` Bart Van Assche
2017-04-16 10:21 ` Ming Lei
2017-04-07 18:23 ` [PATCH v4 0/6] Avoid that scsi-mq and dm-mq queue " Jens Axboe
2017-04-07 18:33 ` Bart Van Assche
2017-04-07 18:39 ` Bart Van Assche
2017-04-07 18:51 ` Jens Axboe
2017-04-12 10:55 ` Benjamin Block
2017-04-12 18:11 ` Bart Van Assche
2017-04-13 12:23 ` Benjamin Block
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407181654.27836-1-bart.vanassche@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox