From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: <linux-block@vger.kernel.org>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Omar Sandoval <osandov@fb.com>, Hannes Reinecke <hare@suse.com>
Subject: [PATCH 2/6] blk-mq: Move the "state" debugfs attribute one level down
Date: Tue, 11 Apr 2017 13:58:38 -0700 [thread overview]
Message-ID: <20170411205842.28137-3-bart.vanassche@sandisk.com> (raw)
In-Reply-To: <20170411205842.28137-1-bart.vanassche@sandisk.com>
Move the "state" attribute from the top level to the "mq" directory
as requested by Omar.
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Omar Sandoval <osandov@fb.com>
Cc: Hannes Reinecke <hare@suse.com>
---
block/blk-mq-debugfs.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index a1ce823578c7..564470d4af52 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -149,11 +149,6 @@ static const struct file_operations blk_queue_flags_fops = {
.write = blk_queue_flags_store,
};
-static const struct blk_mq_debugfs_attr blk_queue_attrs[] = {
- {"state", 0600, &blk_queue_flags_fops},
- {},
-};
-
static void print_stat(struct seq_file *m, struct blk_rq_stat *stat)
{
if (stat->nr_samples) {
@@ -762,6 +757,7 @@ static const struct file_operations ctx_completed_fops = {
static const struct blk_mq_debugfs_attr blk_mq_debugfs_queue_attrs[] = {
{"poll_stat", 0400, &queue_poll_stat_fops},
+ {"state", 0600, &blk_queue_flags_fops},
{},
};
@@ -877,9 +873,6 @@ int blk_mq_debugfs_register_hctxs(struct request_queue *q)
if (!q->debugfs_dir)
return -ENOENT;
- if (!debugfs_create_files(q->debugfs_dir, q, blk_queue_attrs))
- goto err;
-
q->mq_debugfs_dir = debugfs_create_dir("mq", q->debugfs_dir);
if (!q->mq_debugfs_dir)
goto err;
--
2.12.0
next prev parent reply other threads:[~2017-04-11 20:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 20:58 [PATCH 0/6] blk-mq debugfs patches for kernel v4.12 Bart Van Assche
2017-04-11 20:58 ` [PATCH 1/6] blk-mq: Do not invoke queue operations on a dead queue Bart Van Assche
2017-04-13 23:01 ` Omar Sandoval
2017-04-13 23:03 ` Omar Sandoval
2017-04-13 23:05 ` Bart Van Assche
2017-04-14 7:40 ` Omar Sandoval
2017-04-14 16:12 ` Bart Van Assche
2017-04-14 17:13 ` Omar Sandoval
2017-04-14 17:37 ` Bart Van Assche
2017-04-11 20:58 ` Bart Van Assche [this message]
2017-04-13 23:01 ` [PATCH 2/6] blk-mq: Move the "state" debugfs attribute one level down Omar Sandoval
2017-04-11 20:58 ` [PATCH 3/6] blk-mq: Make blk_flags_show() callers append a newline character Bart Van Assche
2017-04-13 23:08 ` Omar Sandoval
2017-04-11 20:58 ` [PATCH 4/6] blk-mq: Show operation, cmd_flags and rq_flags names Bart Van Assche
2017-04-13 23:17 ` Omar Sandoval
2017-04-11 20:58 ` [PATCH 5/6] blk-mq: Add blk_mq_ops.show_rq() Bart Van Assche
2017-04-13 23:21 ` Omar Sandoval
2017-04-14 16:03 ` Bart Van Assche
2017-04-11 20:58 ` [PATCH 6/6] scsi: Implement blk_mq_ops.show_rq() Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411205842.28137-3-bart.vanassche@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox