Linux block layer
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Paolo Valente <paolo.valente@linaro.org>
Cc: kbuild-all@01.org, Jens Axboe <axboe@kernel.dk>,
	Tejun Heo <tj@kernel.org>, Fabio Checconi <fchecconi@gmail.com>,
	Arianna Avanzini <avanzini.arianna@gmail.com>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	ulf.hansson@linaro.org, linus.walleij@linaro.org,
	broonie@kernel.org, Paolo Valente <paolo.valente@linaro.org>
Subject: Re: [PATCH V3 01/16] block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler
Date: Thu, 13 Apr 2017 05:49:32 +0800	[thread overview]
Message-ID: <201704130559.DcdPYftY%fengguang.wu@intel.com> (raw)
In-Reply-To: <20170411134315.44135-2-paolo.valente@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 9549 bytes --]

Hi Paolo,

[auto build test ERROR on block/for-next]
[also build test ERROR on v4.11-rc6 next-20170412]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Paolo-Valente/Introduce-the-BFQ-I-O-scheduler/20170412-021320
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sh 

Note: the linux-review/Paolo-Valente/Introduce-the-BFQ-I-O-scheduler/20170412-021320 HEAD 36eb6533f8b6705991185201f75e98880cd223f7 builds fine.
      It only hurts bisectibility.

All error/warnings (new ones prefixed by >>):

     ^~~~~~~~
   block/bfq-iosched.c:4095:40: error: initializer element is not constant
     __ATTR(name, 0644, bfq_##name##_show, bfq_##name##_store)
                                           ^
   include/linux/sysfs.h:104:11: note: in definition of macro '__ATTR'
     .store = _store,      \
              ^~~~~~
   block/bfq-iosched.c:4105:2: note: in expansion of macro 'BFQ_ATTR'
     BFQ_ATTR(timeout_sync),
     ^~~~~~~~
   block/bfq-iosched.c:4095:40: note: (near initialization for 'bfq_attrs[7].store')
     __ATTR(name, 0644, bfq_##name##_show, bfq_##name##_store)
                                           ^
   include/linux/sysfs.h:104:11: note: in definition of macro '__ATTR'
     .store = _store,      \
              ^~~~~~
   block/bfq-iosched.c:4105:2: note: in expansion of macro 'BFQ_ATTR'
     BFQ_ATTR(timeout_sync),
     ^~~~~~~~
   block/bfq-iosched.c:4095:21: error: initializer element is not constant
     __ATTR(name, 0644, bfq_##name##_show, bfq_##name##_store)
                        ^
   include/linux/sysfs.h:103:10: note: in definition of macro '__ATTR'
     .show = _show,      \
             ^~~~~
   block/bfq-iosched.c:4106:2: note: in expansion of macro 'BFQ_ATTR'
     BFQ_ATTR(strict_guarantees),
     ^~~~~~~~
   block/bfq-iosched.c:4095:21: note: (near initialization for 'bfq_attrs[8].show')
     __ATTR(name, 0644, bfq_##name##_show, bfq_##name##_store)
                        ^
   include/linux/sysfs.h:103:10: note: in definition of macro '__ATTR'
     .show = _show,      \
             ^~~~~
   block/bfq-iosched.c:4106:2: note: in expansion of macro 'BFQ_ATTR'
     BFQ_ATTR(strict_guarantees),
     ^~~~~~~~
   block/bfq-iosched.c:4095:40: error: initializer element is not constant
     __ATTR(name, 0644, bfq_##name##_show, bfq_##name##_store)
                                           ^
   include/linux/sysfs.h:104:11: note: in definition of macro '__ATTR'
     .store = _store,      \
              ^~~~~~
   block/bfq-iosched.c:4106:2: note: in expansion of macro 'BFQ_ATTR'
     BFQ_ATTR(strict_guarantees),
     ^~~~~~~~
   block/bfq-iosched.c:4095:40: note: (near initialization for 'bfq_attrs[8].store')
     __ATTR(name, 0644, bfq_##name##_show, bfq_##name##_store)
                                           ^
   include/linux/sysfs.h:104:11: note: in definition of macro '__ATTR'
     .store = _store,      \
              ^~~~~~
   block/bfq-iosched.c:4106:2: note: in expansion of macro 'BFQ_ATTR'
     BFQ_ATTR(strict_guarantees),
     ^~~~~~~~
   block/bfq-iosched.c:4112:19: error: initializer element is not constant
      .get_rq_priv  = bfq_get_rq_private,
                      ^~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:4112:19: note: (near initialization for 'iosched_bfq_mq.ops.mq.get_rq_priv')
   block/bfq-iosched.c:4113:19: error: initializer element is not constant
      .put_rq_priv  = bfq_put_rq_private,
                      ^~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:4113:19: note: (near initialization for 'iosched_bfq_mq.ops.mq.put_rq_priv')
   block/bfq-iosched.c:4114:16: error: initializer element is not constant
      .exit_icq  = bfq_exit_icq,
                   ^~~~~~~~~~~~
   block/bfq-iosched.c:4114:16: note: (near initialization for 'iosched_bfq_mq.ops.mq.exit_icq')
   block/bfq-iosched.c:4115:22: error: initializer element is not constant
      .insert_requests = bfq_insert_requests,
                         ^~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:4115:22: note: (near initialization for 'iosched_bfq_mq.ops.mq.insert_requests')
   block/bfq-iosched.c:4116:23: error: initializer element is not constant
      .dispatch_request = bfq_dispatch_request,
                          ^~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:4116:23: note: (near initialization for 'iosched_bfq_mq.ops.mq.dispatch_request')
   block/bfq-iosched.c:4124:16: error: initializer element is not constant
      .has_work  = bfq_has_work,
                   ^~~~~~~~~~~~
   block/bfq-iosched.c:4124:16: note: (near initialization for 'iosched_bfq_mq.ops.mq.has_work')
   block/bfq-iosched.c:4125:18: error: initializer element is not constant
      .init_sched  = bfq_init_queue,
                     ^~~~~~~~~~~~~~
   block/bfq-iosched.c:4125:18: note: (near initialization for 'iosched_bfq_mq.ops.mq.init_sched')
   block/bfq-iosched.c:4126:18: error: initializer element is not constant
      .exit_sched  = bfq_exit_queue,
                     ^~~~~~~~~~~~~~
   block/bfq-iosched.c:4126:18: note: (near initialization for 'iosched_bfq_mq.ops.mq.exit_sched')
   block/bfq-iosched.c:4137:19: error: invalid storage class for function 'bfq_init'
    static int __init bfq_init(void)
                      ^~~~~~~~
   block/bfq-iosched.c:4155:20: error: invalid storage class for function 'bfq_exit'
    static void __exit bfq_exit(void)
                       ^~~~~~~~
   In file included from block/bfq-iosched.c:90:0:
   include/linux/module.h:129:42: error: invalid storage class for function '__inittest'
     static inline initcall_t __maybe_unused __inittest(void)  \
                                             ^
   block/bfq-iosched.c:4161:1: note: in expansion of macro 'module_init'
    module_init(bfq_init);
    ^~~~~~~~~~~
>> block/bfq-iosched.c:4161:1: warning: 'alias' attribute ignored [-Wattributes]
   In file included from block/bfq-iosched.c:90:0:
   include/linux/module.h:135:42: error: invalid storage class for function '__exittest'
     static inline exitcall_t __maybe_unused __exittest(void)  \
                                             ^
   block/bfq-iosched.c:4162:1: note: in expansion of macro 'module_exit'
    module_exit(bfq_exit);
    ^~~~~~~~~~~
>> include/linux/module.h:135:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     static inline exitcall_t __maybe_unused __exittest(void)  \
     ^
   block/bfq-iosched.c:4162:1: note: in expansion of macro 'module_exit'
    module_exit(bfq_exit);
    ^~~~~~~~~~~
   block/bfq-iosched.c:4162:1: warning: 'alias' attribute ignored [-Wattributes]
   In file included from include/linux/module.h:18:0,
                    from block/bfq-iosched.c:90:
   include/linux/moduleparam.h:21:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
    static const char __UNIQUE_ID(name)[]       \
    ^
   include/linux/module.h:160:32: note: in expansion of macro '__MODULE_INFO'
    #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info)
                                   ^~~~~~~~~~~~~
   include/linux/module.h:204:32: note: in expansion of macro 'MODULE_INFO'
    #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
                                   ^~~~~~~~~~~
   block/bfq-iosched.c:4164:1: note: in expansion of macro 'MODULE_AUTHOR'
    MODULE_AUTHOR("Paolo Valente");
    ^~~~~~~~~~~~~
>> block/bfq-iosched.c:4166:1: error: expected declaration or statement at end of input
    MODULE_DESCRIPTION("MQ Budget Fair Queueing I/O Scheduler");
    ^~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c: At top level:
   block/bfq-iosched.c:566:13: warning: 'bfq_check_ioprio_change' declared 'static' but never defined [-Wunused-function]
    static void bfq_check_ioprio_change(struct bfq_io_cq *bic, struct bio *bio);
                ^~~~~~~~~~~~~~~~~~~~~~~
   block/bfq-iosched.c:567:13: warning: 'bfq_put_queue' used but never defined
    static void bfq_put_queue(struct bfq_queue *bfqq);
                ^~~~~~~~~~~~~
   block/bfq-iosched.c:568:26: warning: 'bfq_get_queue' used but never defined
    static struct bfq_queue *bfq_get_queue(struct bfq_data *bfqd,
                             ^~~~~~~~~~~~~
   block/bfq-iosched.c:571:13: warning: 'bfq_exit_bfqq' declared 'static' but never defined [-Wunused-function]
    static void bfq_exit_bfqq(struct bfq_data *bfqd, struct bfq_queue *bfqq);
                ^~~~~~~~~~~~~
   block/bfq-iosched.c:1944:13: warning: 'bfq_bfqq_expire' used but never defined
    static void bfq_bfqq_expire(struct bfq_data *bfqd,
                ^~~~~~~~~~~~~~~

vim +4166 block/bfq-iosched.c

  4155	static void __exit bfq_exit(void)
  4156	{
  4157		elv_unregister(&iosched_bfq_mq);
  4158		bfq_slab_kill();
  4159	}
  4160	
> 4161	module_init(bfq_init);
  4162	module_exit(bfq_exit);
  4163	
> 4164	MODULE_AUTHOR("Paolo Valente");
  4165	MODULE_LICENSE("GPL");
> 4166	MODULE_DESCRIPTION("MQ Budget Fair Queueing I/O Scheduler");

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 44365 bytes --]

  parent reply	other threads:[~2017-04-12 21:49 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-11 13:42 [PATCH V3 00/16] Introduce the BFQ I/O scheduler Paolo Valente
2017-04-11 13:43 ` [PATCH V3 01/16] block, bfq: introduce the BFQ-v0 I/O scheduler as an extra scheduler Paolo Valente
2017-04-12 20:19   ` kbuild test robot
2017-04-12 21:49   ` kbuild test robot [this message]
2017-04-11 13:43 ` [PATCH V3 02/16] block, bfq: add full hierarchical scheduling and cgroups support Paolo Valente
2017-04-11 21:47   ` Tejun Heo
2017-04-12  5:22     ` Paolo Valente
2017-04-18  7:04       ` Tejun Heo
2017-04-19  5:33         ` Paolo Valente
2017-04-19  7:08           ` Paolo Valente
2017-04-13  1:59   ` kbuild test robot
2017-04-11 13:43 ` [PATCH V3 03/16] block, bfq: improve throughput boosting Paolo Valente
2017-04-11 13:43 ` [PATCH V3 04/16] block, bfq: modify the peak-rate estimator Paolo Valente
2017-04-11 13:43 ` [PATCH V3 05/16] block, bfq: add more fairness with writes and slow processes Paolo Valente
2017-04-11 13:43 ` [PATCH V3 06/16] block, bfq: improve responsiveness Paolo Valente
2017-04-11 13:43 ` [PATCH V3 07/16] block, bfq: reduce I/O latency for soft real-time applications Paolo Valente
2017-04-11 13:43 ` [PATCH V3 08/16] block, bfq: preserve a low latency also with NCQ-capable drives Paolo Valente
2017-04-11 13:43 ` [PATCH V3 09/16] block, bfq: reduce latency during request-pool saturation Paolo Valente
2017-04-11 13:43 ` [PATCH V3 10/16] block, bfq: add Early Queue Merge (EQM) Paolo Valente
2017-04-11 13:43 ` [PATCH V3 11/16] block, bfq: reduce idling only in symmetric scenarios Paolo Valente
2017-04-11 13:43 ` [PATCH V3 12/16] block, bfq: boost the throughput on NCQ-capable flash-based devices Paolo Valente
2017-04-11 13:43 ` [PATCH V3 13/16] block, bfq: boost the throughput with random I/O on NCQ-capable HDDs Paolo Valente
2017-04-11 13:43 ` [PATCH V3 14/16] block, bfq: handle bursts of queue activations Paolo Valente
2017-04-11 13:43 ` [PATCH V3 15/16] block, bfq: remove all get and put of I/O contexts Paolo Valente
2017-04-11 13:43 ` [PATCH V3 16/16] block, bfq: split bfq-iosched.c into multiple source files Paolo Valente
2017-04-11 14:37 ` [PATCH V3 00/16] Introduce the BFQ I/O scheduler Bart Van Assche
2017-04-11 17:37   ` Paolo Valente
2017-04-11 18:31     ` Bart Van Assche
2017-04-12  6:01       ` Paolo Valente
2017-04-12 15:30         ` Bart Van Assche
2017-04-12 16:08           ` Paolo Valente
2017-04-16  8:14 ` Heinz Diehl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201704130559.DcdPYftY%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=avanzini.arianna@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=broonie@kernel.org \
    --cc=fchecconi@gmail.com \
    --cc=kbuild-all@01.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paolo.valente@linaro.org \
    --cc=tj@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox