From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([65.50.211.133]:46002 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764852AbdDTEyK (ORCPT ); Thu, 20 Apr 2017 00:54:10 -0400 Date: Wed, 19 Apr 2017 21:54:08 -0700 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , Omar Sandoval , Jozef Mikovic Subject: Re: [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched Message-ID: <20170420045408.GB2235@infradead.org> References: <20170415123825.32716-1-ming.lei@redhat.com> <20170420004410.GA16917@ming.t460p> <90e249d6-996c-a8d9-f54d-e8142082bfa5@fb.com> <20170420010346.GC16917@ming.t460p> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170420010346.GC16917@ming.t460p> Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On Thu, Apr 20, 2017 at 09:03:47AM +0800, Ming Lei wrote: > If we don't need to reserve tag for internal command, I am happy > to fix it in the interim. However, the mtip32xx driver has to > ask blk-mq to reserve the tag zero for internal command. Then > if we can't allow the driver to use that reserved tag, it looks > quite awkward, doesn't it? It doesn't. Just offset the hardware tags by 1 from the blk-mq tags. But I'm pretty sure the hardware wouldn't require a specific tag for the internal ops.