From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <osandov@osandov.com>
Return-Path: <osandov@osandov.com>
Date: Fri, 21 Apr 2017 15:11:17 -0700
From: Omar Sandoval <osandov@osandov.com>
To: Bart Van Assche <Bart.VanAssche@sandisk.com>
Cc: "hare@suse.com" <hare@suse.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"osandov@fb.com" <osandov@fb.com>,
	"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH v3 1/8] blk-mq: Register <dev>/queue/mq after having
 registered <dev>/queue
Message-ID: <20170421221117.GC17177@vader.DHCP.thefacebook.com>
References: <20170418232949.5228-1-bart.vanassche@sandisk.com>
 <20170418232949.5228-2-bart.vanassche@sandisk.com>
 <20170421220518.GA17177@vader.DHCP.thefacebook.com>
 <1492812553.2499.11.camel@sandisk.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <1492812553.2499.11.camel@sandisk.com>
List-ID: <linux-block@vger.kernel.org>

On Fri, Apr 21, 2017 at 10:09:14PM +0000, Bart Van Assche wrote:
> On Fri, 2017-04-21 at 15:05 -0700, Omar Sandoval wrote:
> > On Tue, Apr 18, 2017 at 04:29:42PM -0700, Bart Van Assche wrote:
> > > +int blk_mq_register_dev(struct device *dev, struct request_queue *q)
> > > +{
> > > +	int ret;
> > > +
> > > +	ret = mutex_lock_interruptible(&q->sysfs_lock);
> > 
> > Why did you make this interruptible? blk_mq_disable_hotplug() wasn't
> > interruptible before, so now dm_mq_init_request_queue() can fail
> > silently if it is interrupted.
> 
> Hello Omar,
> 
> Whether or not blk_mq_register_dev() should be interruptible is not that
> important to me. I can change this function such that it again ignores
> signals.
> 
> Bart.

Keeping the old behavior is safer, let's do that.