From: Omar Sandoval <osandov@osandov.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Omar Sandoval <osandov@fb.com>,
Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH v4 01/10] blk-mq: Register <dev>/queue/mq after having registered <dev>/queue
Date: Mon, 24 Apr 2017 09:58:31 -0700 [thread overview]
Message-ID: <20170424165831.GE28510@vader.DHCP.thefacebook.com> (raw)
In-Reply-To: <20170421234026.18970-2-bart.vanassche@sandisk.com>
On Fri, Apr 21, 2017 at 04:40:17PM -0700, Bart Van Assche wrote:
> A later patch in this series will modify blk_mq_debugfs_register()
> such that it uses q->kobj.parent to determine the name of a
> request queue. Hence make sure that that pointer is initialized
> before blk_mq_debugfs_register() is called. To avoid lock inversion,
> protect sysfs / debugfs registration with the queue sysfs_lock
> instead of the global mutex all_q_mutex.
Reviewed-by: Omar Sandoval <osandov@fb.com>
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Cc: Omar Sandoval <osandov@fb.com>
> Cc: Hannes Reinecke <hare@suse.com>
> ---
> block/blk-mq-sysfs.c | 35 ++++++++++++++++++++++++++++-------
> block/blk-mq.h | 1 +
> block/blk-sysfs.c | 6 +++---
> 3 files changed, 32 insertions(+), 10 deletions(-)
next prev parent reply other threads:[~2017-04-24 16:58 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 23:40 [PATCH v4 00/10] blk-mq debugfs patches for kernel v4.12 Bart Van Assche
2017-04-21 23:40 ` [PATCH v4 01/10] blk-mq: Register <dev>/queue/mq after having registered <dev>/queue Bart Van Assche
2017-04-24 7:25 ` Hannes Reinecke
2017-04-24 16:58 ` Omar Sandoval [this message]
2017-04-21 23:40 ` [PATCH v4 02/10] blk-mq: Let blk_mq_debugfs_register() look up the queue name Bart Van Assche
2017-04-24 7:25 ` Hannes Reinecke
2017-04-24 16:57 ` Omar Sandoval
2017-04-21 23:40 ` [PATCH v4 03/10] blk-mq-debugfs: Rename functions for registering and unregistering the mq directory Bart Van Assche
2017-04-24 7:26 ` Hannes Reinecke
2017-04-24 16:46 ` Omar Sandoval
2017-04-21 23:40 ` [PATCH v4 04/10] blk-mq: Check blk_mq_debugfs_register() return value Bart Van Assche
2017-04-24 7:26 ` Hannes Reinecke
2017-04-24 16:49 ` Omar Sandoval
2017-04-24 17:05 ` Bart Van Assche
2017-04-21 23:40 ` [PATCH v4 05/10] blk-mq: Unregister debugfs attributes earlier Bart Van Assche
2017-04-24 7:27 ` Hannes Reinecke
2017-04-24 16:55 ` Omar Sandoval
2017-04-24 17:12 ` Bart Van Assche
2017-04-24 17:17 ` Omar Sandoval
2017-04-24 17:24 ` Bart Van Assche
2017-04-24 17:26 ` Omar Sandoval
2017-04-24 17:29 ` Omar Sandoval
2017-04-24 17:34 ` Bart Van Assche
2017-04-21 23:40 ` [PATCH v4 06/10] blk-mq: Move the "state" debugfs attribute one level down Bart Van Assche
2017-04-24 7:28 ` Hannes Reinecke
2017-04-21 23:40 ` [PATCH v4 07/10] blk-mq: Make blk_flags_show() callers append a newline character Bart Van Assche
2017-04-24 7:28 ` Hannes Reinecke
2017-04-21 23:40 ` [PATCH v4 08/10] blk-mq: Show operation, cmd_flags and rq_flags names Bart Van Assche
2017-04-24 7:30 ` Hannes Reinecke
2017-04-21 23:40 ` [PATCH v4 09/10] blk-mq: Add blk_mq_ops.show_rq() Bart Van Assche
2017-04-24 7:32 ` Hannes Reinecke
2017-04-24 21:51 ` Bart Van Assche
2017-04-25 15:16 ` Hannes Reinecke
2017-04-25 15:35 ` Bart Van Assche
2017-04-25 16:34 ` Jens Axboe
2017-04-21 23:40 ` [PATCH v4 10/10] scsi: Implement blk_mq_ops.show_rq() Bart Van Assche
2017-04-24 7:35 ` Hannes Reinecke
2017-04-24 21:35 ` Martin K. Petersen
2017-04-24 21:49 ` Bart Van Assche
2017-04-24 23:19 ` Martin K. Petersen
2017-04-24 23:23 ` Omar Sandoval
2017-04-24 23:33 ` Martin K. Petersen
2017-04-24 23:46 ` Bart Van Assche
2017-04-25 16:40 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170424165831.GE28510@vader.DHCP.thefacebook.com \
--to=osandov@osandov.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@sandisk.com \
--cc=hare@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox