From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Mon, 24 Apr 2017 16:23:59 -0700 From: Omar Sandoval To: "Martin K. Petersen" Cc: Bart Van Assche , "linux-scsi@vger.kernel.org" , "James.Bottomley@HansenPartnership.com" , "linux-block@vger.kernel.org" , "osandov@fb.com" , "hare@suse.com" , "axboe@kernel.dk" Subject: Re: [PATCH v4 10/10] scsi: Implement blk_mq_ops.show_rq() Message-ID: <20170424232359.GA21578@vader.DHCP.thefacebook.com> References: <20170421234026.18970-1-bart.vanassche@sandisk.com> <20170421234026.18970-11-bart.vanassche@sandisk.com> <1493070575.3394.19.camel@sandisk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-ID: On Mon, Apr 24, 2017 at 07:19:50PM -0400, Martin K. Petersen wrote: > > Bart, > > > SCSI tracing has to be enabled before a test is started, produces a > > huge amount of data, and deriving state information from a huge trace > > is far from easy. The information in debugfs provides an easy to read > > overview of the current state without having to analyze megabytes of > > traces, without introducing any slowdown and without having to enable > > any tracing mechanism from beforehand. > > Fair enough. Just seems like there's an obvious overlap in plumbing. > Don't know if that can be leveraged instead of introducing something > completely new? The debugfs infrastructure is already there, and it already supports showing requests. Bart is just exposing the SCSI information.