From: Mike Snitzer <snitzer@redhat.com>
To: hch@lst.de
Cc: Bart Van Assche <Bart.VanAssche@sandisk.com>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
axboe@kernel.dk
Subject: Re: small dm mpath cleanups
Date: Fri, 28 Apr 2017 16:23:58 -0400 [thread overview]
Message-ID: <20170428202358.GA28562@redhat.com> (raw)
In-Reply-To: <20170427063318.GA20345@lst.de>
On Thu, Apr 27 2017 at 2:33am -0400,
hch@lst.de <hch@lst.de> wrote:
> On Wed, Apr 26, 2017 at 06:41:27PM +0000, Bart Van Assche wrote:
> > On Wed, 2017-04-26 at 09:40 +0200, Christoph Hellwig wrote:
> > > this series has some prep patches for my work to have proper, type
> > > checked block errors codes. One fallout of that is that we need to
> > > get rid of how dm overloads a few return values with either internal
> > > positive error codes or negative errno values. This patches does
> > > that, which happens to clean things up a bit, and also allows us
> > > dm to propagate the actual error code in one case where it currently
> > > is dropped on the floor.
> >
> > Hello Christoph,
> >
> > Some patches in this series conflict with patches I would like to end up in
> > the stable kernel series. If I would rebase my patch series on top of your
> > series then that would make it harder to apply my patches on the stable
> > kernel trees. Mike and Christoph, please advise how to proceed.
>
> Bugfixes always go before cleanups. I'd be happy to delay and/or rebase
> any of my patches as needed.
I rebased your patchset ontop of Bart's patchset that I've already
staged in linux-dm.git's 'dm-4.12' branch.
When I try to apply this rebased patchset, it turns out 'dm-4.12' is
missing linux-block.git commit 8fc779805 ("dm mpath: don't check for
req->errors"). Because of this your first patch ("dm mpath: merge
do_end_io into multipath_end_io") won't apply due to conflict.
Not sure how we skin this cat. Unfortunately Jens cannot easily pick
this rebased patchset up because he'll be missing all of Bart's changes
that I've staged in linux-dm.git's 'dm-4.12'.
In hindsight, linux-block.git commit 8fc779805 likely should've been
routed through linux-dm.git. But not a big deal.
How should we skin this cat of getting your changes into 4.12? I could
send a 2nd pull request to Linus after both linux-block.git and
linux-dm.git are merged... sound OK?
Until then, and/or for now, I've staged the fully merged result in
linux-next via linux-dm.git's 'for-next', see:
https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/log/?h=for-next
Mike
next prev parent reply other threads:[~2017-04-28 20:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 7:40 small dm mpath cleanups Christoph Hellwig
2017-04-26 7:40 ` [PATCH 1/4] dm mpath: merge do_end_io into multipath_end_io Christoph Hellwig
2017-04-26 7:40 ` [PATCH 2/4] dm rq: change ->rq_end_io calling conventions Christoph Hellwig
2017-04-26 7:40 ` [PATCH 3/4] dm mpath: simplify multipath_clone_and_map a little bit Christoph Hellwig
2017-04-26 7:40 ` [PATCH 4/4] dm: introduce a new DM_MAPIO_KILL return value Christoph Hellwig
2017-04-26 18:41 ` small dm mpath cleanups Bart Van Assche
2017-04-27 2:24 ` Mike Snitzer
2017-04-27 6:33 ` hch
2017-04-28 20:23 ` Mike Snitzer [this message]
2017-04-28 20:42 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428202358.GA28562@redhat.com \
--to=snitzer@redhat.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).