From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@fb.com>
Cc: linux-block@vger.kernel.org, ming.lei@redhat.com, hch@lst.de
Subject: Re: [PATCH 4/6] mtip32xx: convert internal command issue to block IO path
Date: Tue, 2 May 2017 09:28:10 +0200 [thread overview]
Message-ID: <20170502072810.GA11582@lst.de> (raw)
In-Reply-To: <1493398473-29872-5-git-send-email-axboe@fb.com>
Looks fine for now:
Reviewed-by: Christoph Hellwig <hch@lst.de>
But rather sooner than later we need to make this path at least go
through the normal end_request processing. Without that we're just
bound to run into problems like we had with the tag changes again
when the driver is using the block layer APIs incompletely.
next prev parent reply other threads:[~2017-05-02 7:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 16:54 [PATCH v4 0/6] Fixup mtip32xx for scheduling Jens Axboe
2017-04-28 16:54 ` [PATCH 1/6] mtip32xx: get rid of 'atomic' argument to mtip_exec_internal_command() Jens Axboe
2017-04-28 16:54 ` [PATCH 2/6] mtip32xx: kill atomic argument to mtip_quiesce_io() Jens Axboe
2017-04-28 16:54 ` [PATCH 3/6] mtip32xx: abstract out "are any commands active" helper Jens Axboe
2017-04-28 16:54 ` [PATCH 4/6] mtip32xx: convert internal command issue to block IO path Jens Axboe
2017-05-02 7:28 ` Christoph Hellwig [this message]
2017-05-02 13:53 ` Jens Axboe
2017-05-02 14:47 ` Jens Axboe
2017-05-02 15:09 ` Jens Axboe
2017-05-02 15:16 ` Christoph Hellwig
2017-05-02 15:25 ` Jens Axboe
2017-05-02 15:42 ` Bart Van Assche
2017-05-02 16:00 ` Jens Axboe
2017-04-28 16:54 ` [PATCH 5/6] blk-mq-sched: remove hack that bypasses scheduler for reserved requests Jens Axboe
2017-05-02 7:28 ` Christoph Hellwig
2017-04-28 16:54 ` [PATCH 6/6] Revert "mtip32xx: pass BLK_MQ_F_NO_SCHED" Jens Axboe
2017-05-02 7:28 ` Christoph Hellwig
2017-05-02 12:27 ` [PATCH v4 0/6] Fixup mtip32xx for scheduling Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170502072810.GA11582@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).