From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@fb.com>, linux-block@vger.kernel.org
Cc: Bart Van Assche <bart.vanassche@sandisk.com>,
Omar Sandoval <osandov@fb.com>, Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V2 3/5] blk-mq: don't update q->nr_requests when updating hw queue's depth
Date: Thu, 4 May 2017 03:58:37 +0800 [thread overview]
Message-ID: <20170503195839.6539-4-ming.lei@redhat.com> (raw)
In-Reply-To: <20170503195839.6539-1-ming.lei@redhat.com>
In MQ scheduler, q->nr_requests represents requests in scheduler
queue depth, so don't update it if hw queue's depth is updated.
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
block/blk-mq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index be475ad112ec..681bf33d8de8 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -2643,6 +2643,7 @@ int blk_mq_update_nr_requests(struct request_queue *q, unsigned int nr)
struct blk_mq_tag_set *set = q->tag_set;
struct blk_mq_hw_ctx *hctx;
int i, ret;
+ bool sched = false;
if (!set)
return -EINVAL;
@@ -2664,12 +2665,13 @@ int blk_mq_update_nr_requests(struct request_queue *q, unsigned int nr)
} else {
ret = blk_mq_tag_update_depth(hctx, &hctx->sched_tags,
nr, true);
+ sched = true;
}
if (ret)
break;
}
- if (!ret)
+ if (!ret && sched)
q->nr_requests = nr;
blk_mq_unfreeze_queue(q);
--
2.9.3
next prev parent reply other threads:[~2017-05-03 19:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 19:58 [PATCH V2 0/5] blk-mq: support to use hw tag for scheduling Ming Lei
2017-05-03 19:58 ` [PATCH V2 1/5] blk-mq: introduce BLK_MQ_F_SCHED_USE_HW_TAG Ming Lei
2017-05-03 19:58 ` [PATCH V2 2/5] blk-mq: introduce blk_mq_get_queue_depth() Ming Lei
2017-05-03 19:58 ` Ming Lei [this message]
2017-05-03 19:58 ` [PATCH V2 4/5] blk-mq: use hw tag for scheduling if hw tag space is big enough Ming Lei
2017-05-03 20:14 ` Jens Axboe
2017-05-04 2:12 ` Ming Lei
2017-05-03 19:58 ` [PATCH V2 5/5] blk-mq: allow to use hw tag for shared tags Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170503195839.6539-4-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@fb.com \
--cc=bart.vanassche@sandisk.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox