Re: [PATCH 0/4] blk-mq: support to use hw tag for scheduling

Omar Sandoval
2017-05-03T16:06:27Z

On Wed, May 03, 2017 at 11:38:09PM +0800, Ming Lei wrote:
> On Wed, May 03, 2017 at 09:08:34AM -0600, Jens Axboe wrote:
> > Sounds good. I just wanted to check the numbers here, with the series
> > applied on top of for-linus crashes when switching to kyber. A few hunks
>
> Yeah, I saw that too, it has been fixed in my local tree, :-)

I'm guessing that was this?

static unsigned int kyber_sched_tags_shift(struct kyber_queue_data *kqd)
{
/*
* All of the hardware queues have the same depth, so we can just grab
* the shift of the first one.
*/
return kqd->q->queue_hw_ctx[0]->sched_tags->bitmap_tags.sb.shift;
}

If not, that'll need to be fixed up.

> > threw fuzz, but it looked fine to me. But I bet I fat fingered
> > something. So it'd be great if you could respin against my for-linus
> > branch.
>
> Actually, that is exactly what I am doing, :-)
>
> Thanks,
> Ming