public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: linux-block@vger.kernel.org, kernel-team@fb.com
Subject: Re: Announcing blktests
Date: Mon, 15 May 2017 10:30:36 -0700	[thread overview]
Message-ID: <20170515173036.GA18764@vader.DHCP.thefacebook.com> (raw)
In-Reply-To: <a321ac00-aa4d-a42d-28dd-ebf37a248a1a@suse.de>

On Mon, May 15, 2017 at 09:44:13AM +0200, Johannes Thumshirn wrote:
> On 05/12/2017 08:49 PM, Omar Sandoval wrote:
> > Hi, everyone,
> > 
> > At LSF/MM, we talked about the need for somewhere to dump tests for the
> > block layer/storage stack. I've put together a test suite inspired by
> > xfstests here: https://github.com/osandov/blktests.
> > 
> > I started out with the opinion that we should reuse xfstests for this,
> > but it became clear that the requirements for testing block devices are
> > slightly different, and it diverged significantly from there. In
> > particular, blktests supports:
> > 
> > - Per-device tests. You can configure a list of test devices and the
> >   per-device tests will run on each one (currently in serial, we can
> >   support parallel runs in the future if needed).
> > - No-device tests. Some tests don't need to run on real hardware, and we
> >   can just set up a null-blk or scsi-debug device.
> > - Performance numbers. In addition to the output comparison pass/fail
> >   that xfstests supports, blktests can also report arbitrary test
> >   metrics which don't affect whether the test passes but can be useful
> >   for spotting regressions.
> > 
> > Jens and I wrote up an initial set of tests, but there are a lot more we
> > can still write. I'm also happy to take feature requests, just email me
> > or open an issue on the GitHub repo.
> 
> \o/
> 
> You're my hero :-).
> 
> Do you only accept github pull requests or do you accept patches via
> linux-block as well?

Patches are fine, just format them with `git format-patch
--subject-prefix="PATCH blktests"` so I don't lose them.

> As a side note, I'm currently working on a partition table fuzzer to
> stress block/partitions/*.c a bit. I think this could be included into
> your framework as well (it's only one .c file currently with no external
> dependencies).

Yup, that sounds like a good fit. Currently we don't have any programs
to build, but it'd be easy to add a src/ directory and do what xfstests
does.

Thanks!

  reply	other threads:[~2017-05-15 17:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-12 18:49 Announcing blktests Omar Sandoval
2017-05-15  7:44 ` Johannes Thumshirn
2017-05-15 17:30   ` Omar Sandoval [this message]
2017-05-15 12:13 ` Dmitry Monakhov
2017-05-15 15:30   ` Christoph Hellwig
2017-05-15 17:35   ` Omar Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170515173036.GA18764@vader.DHCP.thefacebook.com \
    --to=osandov@osandov.com \
    --cc=jthumshirn@suse.de \
    --cc=kernel-team@fb.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox