From: Keith Busch <keith.busch@intel.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, Zhang Yi <yizhan@redhat.com>,
linux-block@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] nvme: fix race between removing and reseting failure
Date: Fri, 19 May 2017 11:15:13 -0400 [thread overview]
Message-ID: <20170519151513.GB7850@localhost.localdomain> (raw)
In-Reply-To: <20170519125244.GB22585@ming.t460p>
On Fri, May 19, 2017 at 08:52:45PM +0800, Ming Lei wrote:
> But I still think it may be better to move nvme_kill_queues() into
> nvme_remove_dead_ctrl() as an improvement because during this small
> window page cache can be used up by write application, and no writeback
> can move on meantime.
Yes, I agree that's a better placement for it. I was just concerned
about the reasoning since it would also mean we're still stuck if an
IO timeout occurs while calling del_gendisk. So I'm okay with the patch
as-is, but I'll also look into my other concern.
next prev parent reply other threads:[~2017-05-19 15:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 1:27 [PATCH 0/2] nvme: fix hang in path of removing disk Ming Lei
2017-05-17 1:27 ` [PATCH 1/2] nvme: fix race between removing and reseting failure Ming Lei
2017-05-17 6:38 ` Johannes Thumshirn
2017-05-17 7:01 ` Ming Lei
2017-05-18 13:47 ` Christoph Hellwig
2017-05-18 15:04 ` Ming Lei
2017-05-18 14:13 ` Keith Busch
2017-05-19 12:52 ` Ming Lei
2017-05-19 15:15 ` Keith Busch [this message]
2017-05-19 14:41 ` Jens Axboe
2017-05-19 15:10 ` Ming Lei
2017-05-19 16:40 ` Ming Lei
2017-05-19 16:55 ` yizhan
2017-05-17 1:27 ` [PATCH 2/2] nvme: avoid to hang in remove disk Ming Lei
2017-05-18 13:49 ` Christoph Hellwig
2017-05-18 15:35 ` Ming Lei
2017-05-18 16:06 ` Keith Busch
2017-05-19 13:19 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519151513.GB7850@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
--cc=yizhan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).