Re: [PATCH v2 5/8] blk-mq: update comments on blk_mq_quiesce_queue()

Ming Lei
2017-05-31T09:52:09Z

On Tue, May 30, 2017 at 05:14:44PM +0000, Bart Van Assche wrote:
> On Sat, 2017-05-27 at 22:21 +0800, Ming Lei wrote:
> > /**
> > - * blk_mq_quiesce_queue() - wait until all ongoing queue_rq calls have finished
> > + * blk_mq_quiesce_queue() - wait until all ongoing dispatching have finished
> > * @q: request queue.
> > *
>
> Hello Ming,
>
> The concept of dispatching does not have a meaning to block driver authors who are
> not familiar with the block layer internals. However, every author of a blk-mq driver
> knows what the .queue_rq() function is.

Unfortunately it isn't enough to just block .queue_rq(), did you read the
commit log?

> Additionally, the new comment is grammatically
> incorrect.
> So the above change looks like a step in the wrong direction to me.

Sorry, I simply don't agree, and we have to make it explicit.

--
Ming