From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 1 Jun 2017 10:37:12 +0800 From: Ming Lei To: Bart Van Assche Cc: Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , Omar Sandoval Subject: Re: [PATCH v2 1/4] blk-mq-debugfs: Show atomic request flags Message-ID: <20170601023711.GC23563@ming.t460p> References: <20170531213050.30276-1-bart.vanassche@sandisk.com> <20170531213050.30276-2-bart.vanassche@sandisk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170531213050.30276-2-bart.vanassche@sandisk.com> List-ID: On Wed, May 31, 2017 at 02:30:47PM -0700, Bart Van Assche wrote: > When analyzing e.g. queue lockups it is important to know whether > or not a request has already been started. Hence also show the > atomic request flags. > > Signed-off-by: Bart Van Assche > Reviewed-by: Hannes Reinecke > Cc: Omar Sandoval > Cc: Christoph Hellwig > Cc: Ming Lei > --- > block/blk-mq-debugfs.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c > index 803aed4d7221..d56ddd7a1285 100644 > --- a/block/blk-mq-debugfs.c > +++ b/block/blk-mq-debugfs.c > @@ -267,6 +267,14 @@ static const char *const rqf_name[] = { > }; > #undef RQF_NAME > > +#define RQAF_NAME(name) [REQ_ATOM_##name] = #name > +static const char *const rqaf_name[] = { > + RQAF_NAME(COMPLETE), > + RQAF_NAME(STARTED), > + RQAF_NAME(POLL_SLEPT), > +}; > +#undef RQAF_NAME > + > int __blk_mq_debugfs_rq_show(struct seq_file *m, struct request *rq) > { > const struct blk_mq_ops *const mq_ops = rq->q->mq_ops; > @@ -283,6 +291,8 @@ int __blk_mq_debugfs_rq_show(struct seq_file *m, struct request *rq) > seq_puts(m, ", .rq_flags="); > blk_flags_show(m, (__force unsigned int)rq->rq_flags, rqf_name, > ARRAY_SIZE(rqf_name)); > + seq_puts(m, ", .atomic_flags="); > + blk_flags_show(m, rq->atomic_flags, rqaf_name, ARRAY_SIZE(rqaf_name)); > seq_printf(m, ", .tag=%d, .internal_tag=%d", rq->tag, > rq->internal_tag); > if (mq_ops->show_rq) Reviewed-by: Ming Lei Thanks, Ming