From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@fb.com>,
linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Cc: Bart Van Assche <bart.vanassche@sandisk.com>,
Ming Lei <ming.lei@redhat.com>
Subject: [PATCH v5 01/12] blk-mq: pass correct hctx to blk_mq_try_issue_directly
Date: Tue, 6 Jun 2017 23:21:59 +0800 [thread overview]
Message-ID: <20170606152210.22806-2-ming.lei@redhat.com> (raw)
In-Reply-To: <20170606152210.22806-1-ming.lei@redhat.com>
When direct issue is done on request picked up from plug list,
the hctx need to be updated with the actual hw queue, otherwise
wrong hctx is used and may hurt performance, especially when
wrong SRCU readlock is acquired/released
Reported-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
block/blk-mq.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 58688205c8f4..c13888922e18 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1558,9 +1558,12 @@ static blk_qc_t blk_mq_make_request(struct request_queue *q, struct bio *bio)
blk_mq_put_ctx(data.ctx);
- if (same_queue_rq)
+ if (same_queue_rq) {
+ data.hctx = blk_mq_map_queue(q,
+ same_queue_rq->mq_ctx->cpu);
blk_mq_try_issue_directly(data.hctx, same_queue_rq,
&cookie);
+ }
} else if (q->nr_hw_queues > 1 && is_sync) {
blk_mq_put_ctx(data.ctx);
blk_mq_bio_to_request(rq, bio);
--
2.9.4
next prev parent reply other threads:[~2017-06-06 15:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 15:21 [PATCH v5 00/12] blk-mq: fix & improve queue quiescing Ming Lei
2017-06-06 15:21 ` Ming Lei [this message]
2017-06-06 15:59 ` [PATCH v5 01/12] blk-mq: pass correct hctx to blk_mq_try_issue_directly Bart Van Assche
2017-06-06 15:22 ` [PATCH v5 02/12] blk-mq: fix direct issue Ming Lei
2017-06-06 16:02 ` Bart Van Assche
2017-06-07 2:50 ` Ming Lei
2017-06-06 15:22 ` [PATCH v5 03/12] blk-mq: move blk_mq_quiesce_queue() into include/linux/blk-mq.h Ming Lei
2017-06-06 16:06 ` Bart Van Assche
2017-06-06 15:22 ` [PATCH v5 04/12] blk-mq: introduce blk_mq_quiesce_queue_nowait() Ming Lei
2017-06-06 15:22 ` [PATCH v5 05/12] blk-mq: introduce blk_mq_unquiesce_queue Ming Lei
2017-06-06 15:22 ` [PATCH v5 06/12] blk-mq: use the introduced blk_mq_unquiesce_queue() Ming Lei
2017-06-06 15:22 ` [PATCH v5 07/12] nvme: host: unquiesce queue in nvme_kill_queues() Ming Lei
2017-06-06 15:22 ` [PATCH v5 08/12] blk-mq: use QUEUE_FLAG_QUIESCED to quiesce queue Ming Lei
2017-06-06 16:03 ` Bart Van Assche
2017-06-06 15:22 ` [PATCH v5 09/12] blk-mq: update comments on blk_mq_quiesce_queue() Ming Lei
2017-06-06 15:22 ` [PATCH v5 10/12] blk-mq: don't stop queue for quiescing Ming Lei
2017-06-06 15:22 ` [PATCH v5 11/12] blk-mq: clarify dispatch may not be drained/blocked by stopping queue Ming Lei
2017-06-06 16:07 ` Bart Van Assche
2017-06-06 15:22 ` [PATCH v5 12/12] Revert "blk-mq: don't use sync workqueue flushing from drivers" Ming Lei
2017-06-06 16:03 ` [PATCH v5 00/12] blk-mq: fix & improve queue quiescing Jens Axboe
2017-06-13 2:15 ` Ming Lei
2017-06-18 20:26 ` Jens Axboe
2017-06-18 23:05 ` Bart Van Assche
2017-06-18 23:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606152210.22806-2-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@fb.com \
--cc=bart.vanassche@sandisk.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox